Closed
Bug 1397985
Opened 7 years ago
Closed 7 years ago
Use background instead of background-color in .ruleview-header
Categories
(DevTools :: Inspector: Rules, enhancement)
DevTools
Inspector: Rules
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
808 bytes,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
Seems like I made a typo in Bug 1397133 and wrote --theme-header-background in http://searchfox.org/mozilla-central/source/devtools/client/themes/rules.css#23 when it should've been --theme-toolbar-background like the light theme.
Assignee | ||
Comment 1•7 years ago
|
||
Actually, the mistake was that this needed to be background instead of background-color for the .ruleview-header because the firebug theme is applying a linear gradient.
Assignee | ||
Comment 2•7 years ago
|
||
--theme-header-background was a valid variable in the firebug theme.
Assignee | ||
Updated•7 years ago
|
Summary: Fix typo where --theme-header-background should've been --theme-toolbar-background in rules.css → Use background instead of background-color in .ruleview-header
Assignee | ||
Comment 3•7 years ago
|
||
The problem was that in the firebug theme for the inspector, the background was not being displayed for headers such as "Inherited from html".
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8905748 -
Flags: review?(pbrosset)
Updated•7 years ago
|
Attachment #8905748 -
Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b23fd4108d1 Use background instead of background-color in .ruleview-header. r=pbro
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2b23fd4108d1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•