Closed Bug 1397985 Opened 2 years ago Closed 2 years ago

Use background instead of background-color in .ruleview-header

Categories

(DevTools :: Inspector: Rules, enhancement)

enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Seems like I made a typo in Bug 1397133 and wrote --theme-header-background in http://searchfox.org/mozilla-central/source/devtools/client/themes/rules.css#23 when it should've been --theme-toolbar-background like the light theme.
Actually, the mistake was that this needed to be background instead of background-color for the .ruleview-header because the firebug theme is applying a linear gradient.
--theme-header-background was a valid variable in the firebug theme.
Summary: Fix typo where --theme-header-background should've been --theme-toolbar-background in rules.css → Use background instead of background-color in .ruleview-header
The problem was that in the firebug theme for the inspector, the background was not being displayed for headers such as "Inherited from html".
Attached patch 1397985.patchSplinter Review
Attachment #8905748 - Flags: review?(pbrosset)
Attachment #8905748 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b23fd4108d1
Use background instead of background-color in .ruleview-header. r=pbro
https://hg.mozilla.org/mozilla-central/rev/2b23fd4108d1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.