Closed Bug 1398076 Opened 7 years ago Closed 7 years ago

Top Sites "Edit" button disappears after removing all Top Sites

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- verified

People

(Reporter: cmuresan, Assigned: ursula)

References

Details

Attachments

(1 file)

[Affected versions]:
- Firefox 57.0a1 Build ID 20170907220212

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- browser.newtabpage.activity-stream.enabled is set to true in about:config on a clean new profile.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites and open a new tab.
2. Dismiss all the default Top Sites.
3. Observe the Top Sites section.
 
[Expected results]:
- Empty placeholders are displayed, but the "Edit" button remains.

[Actual results]:
- The "Edit" button disappears along with the last Top Site.

[Notes]:
- The issue is also reproducible if you dismiss Top Sites while you are in the Edit Top Sites menu.
- Attached a screen shot of the issue.
Fixed by https://github.com/mozilla/activity-stream/pull/3461 to be uplifted via bug 1399607.
Blocks: 1399607
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee: nobody → usarracini
Top Sites "Edit" button is displayed after removing all Top Sites.
Verified as fixed using latest Nightly 57.0a1 Build ID 20170915100121, on Windows 10 x64 and Mac 10.12.
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: