Closed
Bug 1398086
Opened 7 years ago
Closed 7 years ago
Remove some unused functions
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
25.78 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
Remove a couple of unused or declared, but not defined functions.
Assignee | ||
Comment 1•7 years ago
|
||
jsarray.cpp - Use existing HandleId to avoid additional rooting in DefineDataProperty jsfun.h - FunctionHasResolveHook is never defined jsmath.h - random_next is never defined jsnum.h - NumberToString(JSContext* cx, double d) is never called jsobj.h - CastAsObject and CastAsObjectJsval are never called - GetPropertyNoGC and GetElementNoGC are never called with receiver = JSObject* - SetClassAndProto is only called in jsobj.cpp, moved there as a static function - The "extern const char js_xxx_str" declarations are unnecessary - FindVariableScope is never defined - GetOwnPropertyDescriptor(JSContext* cx, HandleObject obj, HandleId id, MutableHandleValue vp) is never defined jsstr.h - StringHasPattern is never called jsutil.h - AlignedPtrAndFlag is never used - InitConst and ImplicitCast are never called vm/NativeObject.h - NativeDefineProperty(JSContext* cx, HandleNativeObject obj, PropertyName* name, HandleValue value, GetterOp getter, SetterOp setter, unsigned attrs, ObjectOpResult& result) is never called - NativeDefineElement(JSContext* cx, HandleNativeObject obj, uint32_t index, HandleValue value, JSGetterOp getter, JSSetterOp setter, unsigned attrs, ObjectOpResult& result) is never called vm/PropDesc.h - Delete empty file frontend/BytecodeCompiler.h - CompileAsyncFunctionBody is never defined - BytecodeEmitter::reportStrictModeError(ParseNode* pn, unsigned errorNumber, ...) is never called - BytecodeEmitter::emitToIteratorResult(bool) is never called jspubtd.h: - JSCrossCompartmentCall, JSObjectMap, and JSPropertyName are never defined
Attachment #8905953 -
Flags: review?(till)
Comment 2•7 years ago
|
||
Comment on attachment 8905953 [details] [diff] [review] bug1398086.patch Review of attachment 8905953 [details] [diff] [review]: ----------------------------------------------------------------- There is not a single thing not to like about this patch.
Attachment #8905953 -
Flags: review?(till) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f757ace01ed8acdd25a22968507abe4c74c8525
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/94b2ac8be5db Remove unused functions and classes. r=till
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/94b2ac8be5db
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•