139813 - Need ability to remove new sidebar icon from the personal toolbar

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Scott MacGregor]

using build ID: 2002042403

Just like the rest of the buttons we add to the personal toolbar (app
components, search buttons, etc.) we need a checkbox in prefs under: 
-> Navigator
  --> Select the options you wish to see in the toolbars:
    
There should be a new checkbox here for the sidebar button.

Also, if I hit F9 to get rid of the sidebar shouldn't we hide this new button as
well since it means I don't want to be losing any real-estate to the sidebar. If
I want it back, I'll hit F9 again. I guess that bypasses the goal of making it
easy to bring it back though.....

Comment 1

[Andrew Hagen]

Component --> Preferences. All/all.

The other issue you mention is bug 139691, methinks.

Comment 2

[Gilles Durys]

I see one in build 2002042422 trunk

Comment 3

[Matthew T (active 1999-2002)]

*** Bug 139961 has been marked as a duplicate of this bug. ***

Comment 4

[Gilles Durys]

One a further note, the pref works but does not survive a restart.

Comment 5

[Samir Gehani]

The missing file has been checked in.  The pref will work.  The personal toolbar
code has a flaw in that it requires buttons that don't show by default to be
initialized in all.js to false and to be hidden in the default localstore.rdf. 
But this doesn't fix the problem for profiles that already exist before the
feature lands.  

So special handling will need to be done in the sidebar code to detect if the
sidebar button has no hidden attribute and then set it according the pref value.
 Alternatively, jag and I chatted about fixing the personal toolbar code but his
experience was last time they tried to do that the fallout of problems was not
worth it.

At any rate, that additional code will be a part of bug 134345 which is tracking
whether this feature remains in or is backed out.

Comment 6

[Jesse Ruderman]

Sounds more like "fixed" (or maybe "worksforme") than "invalid" to me.

Comment 7

[Andrew Hagen]

Creating a new profile in 2002042403 (0.9.9+) trunk Windows 98, does not result
in a setting in Preferences to turn this off. This supports reopening the bug.

Comment 8

[sairuh (rarely reading bugmail)]

yes, i see this in the Navigator panel of a new profile i created using
2002.04.25.08-gmake (trunk) comm bits on win2k.

re-marking fixed.

Comment 9

[Andrew Hagen]

After creating a new profile with Build ID: 2002042510, trunk, the icon is
showing but the preference is unchecked. 

Check the preference, close preferences, icon still showing. Open preferences,
uncheck, close prefs, icon not showing.

Now that icon is not showing, open a new window. Icon shows on new window. 

Reopening.

Comment 10

[Samir Gehani]

Feature backed out.  

Comment 11

[sujay]

verified in 4/29 build.