Simplify gfxCoreTextShaper code by removing legacy code only needed on 10.7 and earlier

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

Trunk
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Now that we don't run on pre-10.9 systems, we can assume the kCTWritingDirectionAttributeName attribute will unconditionally be supported, and get rid of the runtime fallback code path that wraps the string in Unicode directionality controls (and the associated complications for string indexing).

(This depends on bug 1324892 to update the SDK we're building against; it looks like that is finally close to landing.)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8905919 - Flags: review?(jmuizelaar) → review+
Priority: -- → P3
Whiteboard: [gfx-noted]
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0aa8826fa414
Simplify gfxCoreTextShaper code by removing legacy code only needed on 10.7 and earlier. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/0aa8826fa414
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
This is busting Mac compiles for Thunderbird:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=fd85506c79b1bbf409bd67c73bf4944ee4c2a07d&selectedJob=131247773

/builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/gfx/thebes/gfxCoreTextShaper.cpp:34:26: error: use of undeclared identifier 'kCTWritingDirectionOverride'; did you mean 'kCTWritingDirectionNatural'? [log…]
 
/builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/gfx/thebes/gfxCoreTextShaper.cpp:45:49: error: use of undeclared identifier 'kCTWritingDirectionAttributeName' [log…]
 
/builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/gfx/thebes/gfxCoreTextShaper.cpp:49:45: error: no matching function for call to 'ArrayLength' [log…] 

Are you missing some include file and haven't noticed it due to unified compilation? We've seen problems like this before.

Or maybe the Macs we use to build are missing the correct SDK?

Sadly a little later this error got obscured by another one: Bug 1398582 comment #21.
Flags: needinfo?(jmuizelaar)
Flags: needinfo?(jkew)
(In reply to Jorg K (GMT+2) from comment #4)
> This is busting Mac compiles for Thunderbird:
> https://treeherder.mozilla.org/#/jobs?repo=comm-
> central&revision=fd85506c79b1bbf409bd67c73bf4944ee4c2a07d&selectedJob=1312477
> 73
> 
> /builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/gfx/thebes/
> gfxCoreTextShaper.cpp:34:26: error: use of undeclared identifier
> 'kCTWritingDirectionOverride'; did you mean 'kCTWritingDirectionNatural'?
> [log…]
>  
> /builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/gfx/thebes/
> gfxCoreTextShaper.cpp:45:49: error: use of undeclared identifier
> 'kCTWritingDirectionAttributeName' [log…]

I believe this means you're building with a too-old SDK (or possibly a newer SDK but with MAC_OS_X_VERSION_MIN_REQUIRED set too low?); these symbols require SDK 10.8 or later.

(For Firefox, the SDK update in bug 1324892 is what allowed us to do this cleanup. I don't know what the status of comm-central builds is, sorry.)
Flags: needinfo?(jkew)
Thanks. Looks like another job for our build/release guy to figure out.
Flags: needinfo?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.