1398134 - Fix warning 'tempValue' may be used uninitialized in UnwrapObjectInternal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nicolas Silva [:nical]]

My terminal is flooded with this warning when I build mozilla-central:

> /home/nical/dev/mozilla/objdir/opt-dbg/dist/include/mozilla/RefPtr.h:193:5: warning: 'tempValue' may be used uninitialized in this function [-Wmaybe-uninitialized]
>      assign_with_AddRef(aRhs);
>      ^~~~~~~~~~~~~~~~~~
> /home/nical/dev/mozilla/objdir/opt-dbg/dist/include/mozilla/dom/BindingUtils.h:289:6: note: 'tempValue' was declared here
>    T* tempValue;
>       ^~~~~~~~~

It's not entirely clear to me if this can cause issues or if tempValue always gets initialized in the recursion and the compiler just can't see it.
In any case with this amount of warnings it becomes easy to miss other potentially important warnings.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Fix the the warning.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/171282de032d
Fix warning in BindingUtils.h. r=bkelly

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/171282de032d

Comment 4

[Ionuț Goldan [:igoldan]]

Improvement noticed:

== Change summary for alert #9677 (as of September 27 2017 07:14 UTC) ==

Improvements:

  3%  compiler warnings summary android-4-0-armv7-api16 opt      1,150.00 -> 1,119.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=9677