1398145 - Inconsistent paste options in context menu when pasting items

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[Oana Botisan, Desktop QA]

[Affected versions]:
- Beta 56.0b7, Beta 56.0b10, Latest Nightly 57, RC 55.0.3

[Affected platforms]:
- Windows 10 x64, Ubuntu 16.04 x64, Mac OS X10.11

[Steps to reproduce]:
1. Access Bookmark Library.
2. Right-click on a bookmark and select 'Cut'.
3. Paste it in the same folder.
4. Repeat the steps 2 and 3 and observe the behaviour.

[Expected result]:
- Both times you can paste the bookmark.

[Actual result]:
- Only the second time you can paste the bookmark.

[Regression range]:
- If this is a regression I will try to find it as soon as possible. 

[Additional notes]:
- This happens every 2 attempts (on the first try you can't paste the bookmark, the second time you can, the third time you can't, the forth time you can and so on).

Comment 1

[Ciprian Georgiu, Desktop QA]

Reproduced this bug with latest Nightly 57.0a1 on Win 10.

Comment 2

[Mark Banner (:standard8)]

Cut & paste within the same folder works every time for me. The strange bit is the bookmark sometimes stays greyed out after it has been pasted back in.

Oana, are you sure this happens on Mac as well? It feels a little like bug 1386513, but that is Windows only.

Also, can you try with browser.places.useAsyncTransactions set to false (and restarted), I'm wondering if it is that or not.

Comment 3

[Oana Botisan, Desktop QA]

(In reply to Mark Banner (:standard8) from comment #2)
> Cut & paste within the same folder works every time for me. The strange bit
> is the bookmark sometimes stays greyed out after it has been pasted back in.
> 
> Oana, are you sure this happens on Mac as well? It feels a little like bug
> 1386513, but that is Windows only.
> 
> Also, can you try with browser.places.useAsyncTransactions set to false (and
> restarted), I'm wondering if it is that or not.

I checked again on MacOS X10.11 and the bug is reproducing. The first time I try to cut a bookmark and try to paste it in the same folder, the 'Paste' option from context menu stays inactive. 

I also changed the pref browser.places.useAsyncTransactions to false, but the bug was still reproducing. I noticed as well that sometimes the bookmark stays grayed out, but this one I think only happened after I changed the pref.

Comment 4

[Mark Banner (:standard8)]

Oana, could you provide a video of this, preferably based on a fresh profile & latest nightly. I really haven't seen this at all.

Also, check for any error messages on the browser console.

Comment 5

[Oana Botisan, Desktop QA]

Attachment: cut-paste bookrmarks

Sorry I didn't answer you sooner. 
I retested using latest Nightly 61.0a1 on Mac OS 10.10 and I got another behaviour. It seems to me that it doesn't happen to all the bookmarks. You can see the  screen recording by accessing this link. And even for those that can't be paste, if the focus is on other links than you can paste it. 

I hope this helps.

Comment 6

[Mark Banner (:standard8)]

Alright, I finally figured out the real issue as determined by the video.

STR

1) Open the Bookmarks Library, go to a folder with a few bookmarks in.
2) Right-click a bookmark and select "Cut".
3) Right-click the same bookmark again

=> Paste is disabled.

4) Right-click in the blank space at bottom of folder

=> Paste is still disabled.

5) Right-click on a different bookmark

=> Paste is enabled.

6) Right-click on the original bookmark

=> Paste is enabled.

So the issue here, is that we're disabling being able to paste in the same place when we initially cut (which makes sense), but then when we move elsewhere and back again, we're not re-asserting that paste is disabled.

The issue with clicking the blank space at the bottom of the folder is probably similar to bug 647218 - we're not changing the selection, so the context menu "thinks" the active bookmark is the one originally cut. In theory, this should probably allow pasting at the bottom of the folder.