Closed Bug 1398179 Opened 7 years ago Closed 4 years ago

Intermittent TEST-UNEXPECTED-TIMEOUT | /service-workers/service-worker/clients-get-cross-origin.https.html | Test Clients.get() cross origin - Test timed out

Categories

(Core :: DOM: Service Workers, defect, P2)

Product:
Core
Component:
DOM: Service Workers
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(2 files, 1 obsolete file)

Disable on Linux and OS X
802 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review
Bug 1398179 - re-enable clients-get-cross-origin.https.html WPT r?#dom-workers-and-storage-reviewers
47 bytes, text/x-phabricator-request
Details | Review
In the last 7 days we have 30 failures. They occur on Linux32, Linux x64, linux32-stylo-disabled, linux64-stylo-disabled and the affected build type is debug. Recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=162510649&lineNumber=24419 and a relevant part of it: [task 2018-02-15T21:40:58.485Z] 21:40:58 INFO - TEST-UNEXPECTED-TIMEOUT | /service-workers/service-worker/clients-get-cross-origin.https.html | Test Clients.get() cross origin - Test timed out [task 2018-02-15T21:40:58.486Z] 21:40:58 INFO - TEST-UNEXPECTED-TIMEOUT | /service-workers/service-worker/clients-get-cross-origin.https.html | expected OK [task 2018-02-15T21:40:58.488Z] 21:40:58 INFO - TEST-INFO took 30500ms
Flags: needinfo?(mdaly)
Whiteboard: [stockwell needswork]
Flags: needinfo?(mdaly)
Priority: -- → P2
In the last 7 days there are 67 failures. Most of them are on Linux and a few on OS-X. Build type "debug" Recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=164031645&lineNumber=24313 :mdaly, can you please take a look?
Flags: needinfo?(mdaly)
:catalinb when you have time can you give this a look?
Flags: needinfo?(mdaly) → needinfo?(catalin.badea392)
Assignee: nobody → catalin.badea392
Attached patch Disable on Linux and OS X (obsolete) — — Splinter Review
Made a patch for disabling on Linux and OS X both debug. Could you please review it? Thanks.
Attachment #8955754 - Flags: review?(jmaher)
Comment on attachment 8955754 [details] [diff] [review] Disable on Linux and OS X Review of attachment 8955754 [details] [diff] [review]: ----------------------------------------------------------------- looks good
Attachment #8955754 - Flags: review?(jmaher) → review+
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b0c4930429a Disable /service-workers/service-worker/clients-get-cross-origin.https.html on Linux and OS X for frequent failures. r=jmaher
Keywords: checkin-needed
After an input from Aryx I modified the file again. It was a problem with "&&". Sorry to be giving you all this trouble of keep reviewing these patches. Thanks Joel.
Attachment #8955754 - Attachment is obsolete: true
Attachment #8955791 - Flags: review?(jmaher)
Comment on attachment 8955791 [details] [diff] [review] Disable on Linux and OS X Review of attachment 8955791 [details] [diff] [review]: ----------------------------------------------------------------- ok, glad we are figuring this out, thanks for your work on this.
Attachment #8955791 - Flags: review?(jmaher) → review+
Flags: needinfo?(jmaher)
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1fabb00546a7 Disable /service-workers/service-worker/clients-get-cross-origin.https.html on Linux and OS X for frequent failures. r=jmaher
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Won't be able to work on this.
Assignee: catalin.badea392 → nobody
Flags: needinfo?(catalin.badea392) → needinfo?(mdaly)
Andrew, when you have spare time.
Flags: needinfo?(mdaly) → needinfo?(bugmail)

Hi Perry, should we try to reenable this test in order to check, if it is still broken?

Flags: needinfo?(perry)

Yeah, we should. All the logs in the comments are too old to be viewed too.

Flags: needinfo?(perry)
Flags: needinfo?(bugmail)

Re-enabling after 2 years of being disabled. If the underlying issue hasn't been
resolved, it'd be good to at least get updated logs for the intermittent failure.
The logs linked to on the bug comments are all too old to view anymore.

Assignee: nobody → perry
Status: NEW → ASSIGNED
Pushed by pjiang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc6453f6fd69 re-enable clients-get-cross-origin.https.html WPT r=dom-workers-and-storage-reviewers,edenchuang

Hi Cosmin, I am a bit unsure if we should clear the [stockwell disabled] whiteboard then, too?

Flags: needinfo?(csabou)

Yes, because the test in no longer disabled, thanks for pointing it out. No failures since then looks good.

Flags: needinfo?(csabou)
Whiteboard: [stockwell disabled]
Assignee: perry → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: