1398217 - Legacy that require restart do not upgrade to webextensions

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P2)

Description

[marius.santa]

[Affected versions]:
Firefox 57.0a1 from https://bugzilla.mozilla.org/show_bug.cgi?id=1353194#c33

[Affected platforms]:
Windows 10 64-bit

[Steps to reproduce]:
1.Launch Firefox Release with a clean profile.
2.Install the following legacy add-on: https://addons.mozilla.org/en-US/firefox/addon/adblocker-ultimate/versions/
3.When prompted for restart select "Not Now".
4.Close the browser and open the same profile using the build from https://bugzilla.mozilla.org/show_bug.cgi?id=1353194#c33

 
[Expected Results]:
The addon is upgraded to the latest webextension version.

[Actual Results]:
- The legacy add-on is not updated and is present in the "Legacy Extensions" tab.
- See Gif.

Comment 1

[Andrew Swan [:aswan]]

The startup check only handles extensions that were previously enabled that have become disabled as a result of the upgrade.  In this case, the old extension was never enabled so it doesn't get checked.  The purpose of doing the check at startup is to preserve continuity for extensions that were previously enabled.  Since this extension wasn't previously enabled, I think waiting for a background update check to pick it up is fine.

From a quick glance, I think this specific case would actually be a significant amount of work to address, I really don't think its worth it so I'm inclined to close this as WONTFIX.  Andy, second opinion?

Comment 2

[Andy McKay]

I think the cause of this is that Marius said "Not Now" to the install of the extension. That seems like an edge case and I agree with aswan, that's fine.

If the user completes the restart and the extension is enabled, then browser is restarted, does it still upgrade? That's the use case that is of concern.

So I think agree with aswan, just wanted to double check on the cause.

Comment 3

[Andrew Swan [:aswan]]

I've tested the case Andy mentioned in comment 2 and I'm pretty sure QA has too.

Comment 4

[marius.santa]

Attachment: no upgrade with restart.gif

Comment 5

[marius.santa]

The scenario also reproduces if the user does not click on "Not Now" and just upgrades the browser without clicking on "Restart Now" but that seems to be more or less the same thing.
If the user performs the restart and only after upgrades the browser, the legacy add-on is upgraded correctly to the latest webextension version(if it has one).

Comment 6

[marius.santa]

Tested upgrade with build Firefox 57.0a1 from https://bugzilla.mozilla.org/show_bug.cgi?id=1353194#c33 on MacOS 10.12.3 and updated the tracking flags.