Test annotations for Quantum Render

RESOLVED FIXED in Firefox 57

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gbrown, Assigned: kats)

Tracking

Trunk
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

mozinfo knows about "asan" and "stylo", but I do not see any allowance made for Quantum Render. When a test fails only on, say, linux64-qr, is there a way to skip the test only on that test platform?
(In reply to Geoff Brown [:gbrown] from comment #1)
> https://bugzilla.mozilla.org/show_bug.cgi?id=1380971#c15

The discussion in that bug is about reftests. mozinfo doesn't apply to reftests.
I'm happy to see "webrender" in the reftest sandbox, and that absolutely addresses my primary concern - thanks!

If there is also the possibility of a qr-specific failure in a mochitest or other test suite, we should have a similar way of annotating tests in those suites.
Agreed that we'll need this in mozinfo as well.
Blocks: 1334189
Assignee: nobody → bugmail
BTW the try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e7703ae5033c250baaf47aeba707e2b0038927d includes this patch, as well as a patch that uses "skip-if = webrender" on the test in gfx/tests/chrome/chrome.ini. It seems to work fine - the M-e10s(gpu) job for linux64 still runs the test, but the corresponding QuantumRender job skips the test. I also tested locally with `MOZ_WEBRENDER=1 ./mach test ...` and got similar results which is good.
Comment on attachment 8910456 [details]
Bug 1398223 - Add a webrender flag to mozinfo to allow using it in mochitest.ini conditions.

https://reviewboard.mozilla.org/r/181898/#review187276

Looks good - thanks!
Attachment #8910456 - Flags: review?(gbrown) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36d6f521c2b2
Add a webrender flag to mozinfo to allow using it in mochitest.ini conditions. r=gbrown
https://hg.mozilla.org/mozilla-central/rev/36d6f521c2b2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.