1398223 - Test annotations for Quantum Render

Status: RESOLVED FIXED

(Testing :: General, enhancement)

Description

[Geoff Brown [:gbrown]]

mozinfo knows about "asan" and "stylo", but I do not see any allowance made for Quantum Render. When a test fails only on, say, linux64-qr, is there a way to skip the test only on that test platform?

Comment 1

[Geoff Brown [:gbrown]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1380971#c15

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Geoff Brown [:gbrown] from comment #1)
> https://bugzilla.mozilla.org/show_bug.cgi?id=1380971#c15

The discussion in that bug is about reftests. mozinfo doesn't apply to reftests.

Comment 3

[Geoff Brown [:gbrown]]

I'm happy to see "webrender" in the reftest sandbox, and that absolutely addresses my primary concern - thanks!

If there is also the possibility of a qr-specific failure in a mochitest or other test suite, we should have a similar way of annotating tests in those suites.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Agreed that we'll need this in mozinfo as well.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1398223 - Add a webrender flag to mozinfo to allow using it in mochitest.ini conditions.

Review commit: https://reviewboard.mozilla.org/r/181898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181898/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

BTW the try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e7703ae5033c250baaf47aeba707e2b0038927d includes this patch, as well as a patch that uses "skip-if = webrender" on the test in gfx/tests/chrome/chrome.ini. It seems to work fine - the M-e10s(gpu) job for linux64 still runs the test, but the corresponding QuantumRender job skips the test. I also tested locally with `MOZ_WEBRENDER=1 ./mach test ...` and got similar results which is good.

Comment 7

[Geoff Brown [:gbrown]]

Comment on attachment 8910456 [details]
Bug 1398223 - Add a webrender flag to mozinfo to allow using it in mochitest.ini conditions.

https://reviewboard.mozilla.org/r/181898/#review187276

Looks good - thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36d6f521c2b2
Add a webrender flag to mozinfo to allow using it in mochitest.ini conditions. r=gbrown

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/36d6f521c2b2