Closed Bug 1398230 Opened 7 years ago Closed 7 years ago

"Open a new tab" and "List all tabs" move when dragging tab

Categories

(Firefox :: Tabbed Browser, defect)

57 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: Oriol, Assigned: jaws)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image screencast.gif
1. Keep pressing Ctrl+T until the tabbar overflows with tabs
2. Click some tab and drag it

Result: "Open a new tab" and "List all tabs" are shifted downwards

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=865d5faef4a7d034500efae76e66e5216541b3d9&tochange=481d7cc2f6f06ea35794403dc9291d277910d6b9
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8906052 [details]
Bug 1398230 - Apply the padding-bottom to other children of the TabsToolbar when a tab is moving to keep them aligned correctly.

https://reviewboard.mozilla.org/r/177804/#review183206

lgtm, fwiw. Feel free to either wait for Dão's review as well or land - not sure if you were looking for something specific from Dão.
Attachment #8906052 - Flags: review+
Attachment #8906052 - Flags: review?(dao+bmo)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26606cf1e39b
Apply the padding-bottom to other children of the TabsToolbar when a tab is moving to keep them aligned correctly. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/26606cf1e39b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this bug with Nightly 57.0a1 (2017-09-08) in Windows 10 (64-bit).

This bug's fix is verified with latest Nightly 57.0a1 (64-bit).

Build ID   :   20170914100122
User Agent :   Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday 20170913]
In Private mode, the private mask icon on the left of the tab bar, still moves in latest nightly build (20170915100121) on Linux 64bit (at least). Same, but both in Private and normal mode, goes for "bookmarks toolbar items" if someone puts it there. No other element that I tried to move there is affected.
Flags: needinfo?(jaws)
See Also: → 1400556
(In reply to tgn-ff from comment #7)
> In Private mode, the private mask icon on the left of the tab bar, still
> moves in latest nightly build (20170915100121) on Linux 64bit (at least).
> Same, but both in Private and normal mode, goes for "bookmarks toolbar
> items" if someone puts it there. No other element that I tried to move there
> is affected.

I'm fixing this in bug 1400556.
Flags: needinfo?(jaws)
Flags: in-qa-testsuite+
You need to log in before you can comment on or make changes to this bug.