Closed
Bug 1398239
Opened 7 years ago
Closed 7 years ago
Add prerendering capability, Highlights diversity and bug fixes to Activity Stream
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: Mardak, Assigned: k88hudson)
References
Details
(Whiteboard: [export])
User Story
Attachments
(1 file)
No description provided.
Reporter | ||
Updated•7 years ago
|
Summary: Add ... and bug fixes to Activity Stream → Add prerendering capability, Highlights diversity and bug fixes to Activity Stream
Reporter | ||
Updated•7 years ago
|
User Story: (updated)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8906783 -
Flags: review?(edilee)
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8906783 [details] Bug 1398239 - Add prerendering capability, Highlights diversity and bug fixes to Activity Stream https://reviewboard.mozilla.org/r/178514/#review183530 I believe we do want to fix at least the broken `<link rel=icon/>` ::: browser/extensions/activity-stream/data/content/activity-stream.html:6 (Diff revision 1) > <!doctype html> > -<html lang="en-us" dir="ltr"> > +<html lang="" dir="ltr"> > <head> > <meta charset="utf-8"> > <meta http-equiv="Content-Security-Policy-Report-Only" content="script-src 'unsafe-inline'; img-src http: https: data: blob:; style-src 'unsafe-inline'; child-src 'none'; object-src 'none'; report-uri https://tiles.services.mozilla.com/v4/links/activity-stream/csp"> > - <title></title> > + <title>New Tab</title> This will cause other locales to see "New Tab" briefly before the strings come in. I believe when it's empty, it'll use a Firefox-provided "New Tab" (localized) string. ::: browser/extensions/activity-stream/data/content/activity-stream.html:10 (Diff revision 1) > <meta http-equiv="Content-Security-Policy-Report-Only" content="script-src 'unsafe-inline'; img-src http: https: data: blob:; style-src 'unsafe-inline'; child-src 'none'; object-src 'none'; report-uri https://tiles.services.mozilla.com/v4/links/activity-stream/csp"> > - <title></title> > + <title>New Tab</title> > <link rel="icon" type="image/png" id="favicon" href="chrome://branding/content/icon32.png"/> > <link rel="stylesheet" href="chrome://browser/content/contentSearchUI.css" /> > <link rel="stylesheet" href="resource://activity-stream/data/content/activity-stream.css" /> > + <link rel="icon" type="image/svg+xml" href="resource://activity-stream/img/newtab-icon.svg"> This change looks undesired. The icon doesn't exist?
Attachment #8906783 -
Flags: review?(edilee)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8906783 [details] Bug 1398239 - Add prerendering capability, Highlights diversity and bug fixes to Activity Stream https://reviewboard.mozilla.org/r/178514/#review183534 yay webpack or whatever update for not expanding destructuring
Attachment #8906783 -
Flags: review?(edilee) → review+
Reporter | ||
Updated•7 years ago
|
User Story: (updated)
Reporter | ||
Updated•7 years ago
|
User Story: (updated)
Reporter | ||
Updated•7 years ago
|
Pushed by edilee@gmail.com: https://hg.mozilla.org/integration/autoland/rev/57f1221bf914 Add prerendering capability, Highlights diversity and bug fixes to Activity Stream r=Mardak
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → khudson
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/57f1221bf914
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 7•7 years ago
|
||
mistake |
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 I've retested this issue on Windows 10 and Ubuntu 16.04 with the latest Nightly (Build ID 20170913220121) on Mac 10.12 with Nightly build ID 20170914100122. When a Top Site URL is edited a new one is still created and the "edited" one is moved to the right. This is the exact behavior described in comment 0. @Mardak, are the changes not in the latest Nightly?
Status: RESOLVED → REOPENED
Flags: needinfo?(edilee)
Resolution: FIXED → ---
Comment 8•7 years ago
|
||
Commented on a different bug.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Flags: needinfo?(edilee)
Resolution: --- → FIXED
Reporter | ||
Updated•6 years ago
|
Whiteboard: [export]
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•