Closed
Bug 1398273
Opened 7 years ago
Closed 7 years ago
Rename legacy-iterator to property-iterator in jsiter.cpp
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
16.14 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
builtin/Iterator.js: - LegacyIterator() and LegacyIteratorShim() are no longer needed - Also inlined NewLegacyIterator() into its sole caller (LegacyGeneratorIteratorShim) jit-test/lib/range.js - This file was only included, but its range() method was never called jsfriendapi.h: - Removed no longer used JSITER_KEYVALUE jsiter.cpp: - Renamed multiple methods to use "property iterator" instead of "legacy iterator" to reflect their current use tests/ecma_N: - And updated the tests in tests/ecma_N to no longer special-case __iterator__ resp. directly throw an error
Attachment #8906120 -
Flags: review?(luke)
Updated•7 years ago
|
Attachment #8906120 -
Flags: review?(luke) → review+
Assignee | ||
Comment 2•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c81871eea186ad47a320f979b186ca6b7a7d9325
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e62cc9325a2b Rename LegacyIterator to PropertyIterator in jsiter. r=luke
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e62cc9325a2b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•