Closed Bug 1398273 Opened 3 years ago Closed 3 years ago

Rename legacy-iterator to property-iterator in jsiter.cpp

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

No description provided.
Attached patch bug1398273.patchSplinter Review
builtin/Iterator.js:
- LegacyIterator() and LegacyIteratorShim() are no longer needed
- Also inlined NewLegacyIterator() into its sole caller (LegacyGeneratorIteratorShim)

jit-test/lib/range.js
- This file was only included, but its range() method was never called

jsfriendapi.h:
- Removed no longer used JSITER_KEYVALUE

jsiter.cpp:
- Renamed multiple methods to use "property iterator" instead of "legacy iterator" to reflect their current use

tests/ecma_N:
- And updated the tests in tests/ecma_N to no longer special-case __iterator__ resp. directly throw an error
Attachment #8906120 - Flags: review?(luke)
Attachment #8906120 - Flags: review?(luke) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e62cc9325a2b
Rename LegacyIterator to PropertyIterator in jsiter. r=luke
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e62cc9325a2b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.