Closed
Bug 1398327
Opened 7 years ago
Closed 7 years ago
Inconsistencies in permissions l10n messages between mobile and desktop
Categories
(WebExtensions :: Android, defect, P1)
Tracking
(firefox57 verified)
VERIFIED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: aswan, Assigned: aswan)
References
Details
Attachments
(3 files)
From https://bugzilla.mozilla.org/show_bug.cgi?id=1379833#c60 Francisco pointed out that new permissions strings were landed on desktop between the time I started working on that bug and the time it landed. These need to be synced.
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Comment 1•7 years ago
|
||
Side question: someone noted that we added 2 access keys to /mobile in bug 1379833, and it doesn't make a lot of sense. I quickly looked at the code, and it doesn't seem easy to get rid of them, since it's shared in /toolkit between desktop and Android. Can you confirm if that's the case?
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #1) > Side question: someone noted that we added 2 access keys to /mobile in bug > 1379833, and it doesn't make a lot of sense. > > I quickly looked at the code, and it doesn't seem easy to get rid of them, > since it's shared in /toolkit between desktop and Android. Can you confirm > if that's the case? Thanks for pointing this out, I'll address that in this bug too.
Summary: sync permissions messages with desktop → Inconsistencies in permissions l10n messages between mobile and desktop
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8906790 -
Flags: review?(tomica)
Attachment #8906791 -
Flags: review?(francesco.lodolo)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8906790 [details] Bug 1398327 Part 1: Skip permission dialog access keys on Android https://reviewboard.mozilla.org/r/178520/#review183558 ::: toolkit/components/extensions/Extension.jsm:903 (Diff revision 1) > // We deliberately do not include all permissions in the prompt. > // So if we don't find one then just skip it. > } > } > > + const haveAccessKeys = (AppConstants.platform != "android"); nit: !==
Attachment #8906790 -
Flags: review?(tomica) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8906791 [details] Bug 1398327 Part 2: Sync extension permission strings from desktop to android https://reviewboard.mozilla.org/r/178522/#review183644
Attachment #8906791 -
Flags: review?(francesco.lodolo) → review+
Comment 7•7 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #6) > Comment on attachment 8906791 [details] > Bug 1398327 Part 2: Sync extension permission strings from desktop to android > > https://reviewboard.mozilla.org/r/178522/#review183644 Looks like you just landed another one… https://bugzilla.mozilla.org/show_bug.cgi?id=1394553
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by aswan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e2e49f43ea7 Part 1: Skip permission dialog access keys on Android r=zombie https://hg.mozilla.org/integration/autoland/rev/982a038ad064 Part 2: Sync extension permission strings from desktop to android r=flod
Updated•7 years ago
|
status-firefox57:
--- → affected
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e2e49f43ea7 https://hg.mozilla.org/mozilla-central/rev/982a038ad064
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 14•7 years ago
|
||
This issue is verified as fixed on Fennec 57.0a1 (2017-09-21) under Android 7.1.2 The new permissions strings (browsingData, devtools, downloads.open and proxy ) that were added are displayed in the permission pop-up. The "find" API is only supported on desktop and in this case is not displayed in the pop-up. Please see the attached screenshot.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•