Closed
Bug 1398345
Opened 7 years ago
Closed 7 years ago
mozrunner doesn't find llvm-symbolizer and doesn't get memory size on Mac
Categories
(Testing :: Mozbase, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: myk, Assigned: myk)
Details
Attachments
(1 file)
2.04 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
mozrunner doesn't find llvm-symbolizer on Mac because it's looking in the wrong place (xrePath, i.e. Contents/); and it fails to get the memory size on Mac because it calls |free|, which doesn't exist there. This patch makes mozrunner look for llvm-symbolizer in the right place (ldLibraryPath, i.e. Contents/MacOS/) and call |sysctl hw.memsize| to get the memory size on Mac.
Attachment #8906121 -
Flags: review?(ahalberstadt)
Comment 1•7 years ago
|
||
Comment on attachment 8906121 [details] [diff] [review] find llvm-symbolizer, get memory size on Mac Review of attachment 8906121 [details] [diff] [review]: ----------------------------------------------------------------- I don't have a machine to verify this, but lgtm!
Attachment #8906121 -
Flags: review?(ahalberstadt) → review+
Pushed by myk@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bc1f526a6152 find llvm-symbolizer, get memory size on Mac; r=ahal
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc1f526a6152
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•