Closed Bug 1398379 Opened 2 years ago Closed 2 years ago

Remove GetRootScrollFrameAsScrollableExternal() (and adjust callers to use GetRootScrollFrameAsScrollable)

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(2 files)

We have these three functions:
============
  /*
   * Get root scroll frame from FrameManager()->GetRootFrame().
   */
  nsIFrame* GetRootScrollFrame() const;

  /*
   * The same as GetRootScrollFrame, but returns an nsIScrollableFrame
   */
  nsIScrollableFrame* GetRootScrollFrameAsScrollable() const;

  /*
   * The same as GetRootScrollFrame, but returns an nsIScrollableFrame.
   * Can be called by code not linked into gklayout.
   */
  virtual nsIScrollableFrame* GetRootScrollFrameAsScrollableExternal() const;
============
https://dxr.mozilla.org/mozilla-central/rev/37b95547f0d27565452136d16b2df2857be840f6/layout/base/nsIPresShell.h#403-417

The last two are identical except that the last one "Can be called by code not linked into gklayout."  This is from pre-libxul days, I think, and it doesn't serve any purpose anymore.  We should convert all of its callers to use its non-"External"-flavored variant, and get rid of it.
Summary: Remove callers to GetRootScrollFrameAsScrollableExternal() → Remove GetRootScrollFrameAsScrollableExternal() (and adjust callers to use GetRootScrollFrameAsScrollable)
Priority: -- → P3
Comment on attachment 8906171 [details]
Bug 1398379 part 1: Make callers of GetRootScrollFrameAsScrollableExternal() use its equivalent non-"External" version instead.

https://reviewboard.mozilla.org/r/177916/#review182938
Attachment #8906171 - Flags: review?(mats) → review+
Comment on attachment 8906172 [details]
Bug 1398379 part 2: Remove GetRootScrollFrameAsScrollableExternal() since it has no more callers.

https://reviewboard.mozilla.org/r/177918/#review182940
Attachment #8906172 - Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e962926d2f8
part 1: Make callers of GetRootScrollFrameAsScrollableExternal() use its equivalent non-"External" version instead. r=mats
https://hg.mozilla.org/integration/autoland/rev/1bf55ab6c1c7
part 2: Remove GetRootScrollFrameAsScrollableExternal() since it has no more callers. r=mats
You need to log in before you can comment on or make changes to this bug.