Closed Bug 1398431 Opened 7 years ago Closed 7 years ago

Intermittent toolkit/components/telemetry/tests/unit/test_TelemetrySession.js | test_checkSubsessionHistograms - [test_checkSubsessionHistograms : 783] Adding values should be picked up again (CYCLE_COLLECTOR_WORKER) - false == true

Categories

(Toolkit :: Telemetry, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: chutten)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

I'm reproducing this fairly easily under chaos mode today.

Near as I can tell from code inspection, there's a non-main-thread CC that runs between lines 874 and 875 of test_TelemetrySession.js so that there are CYCLE_COLLECTOR_WORKER* probes in the subsession snapshots but not the session snapshots.

Near as I can tell, this is unavoidable without atomicity primitives in JavaScript (lolz)

So what we can do instead is specifically ignore probes in the CYCLE_COLLECTOR_WORKER* family. I have a patch for this locally. Just running it a few times to make sure it actually works.
Assignee: nobody → chutten
Priority: P5 → P1
Comment on attachment 8907625 [details]
bug 1398431 - Don't let off-thread CCs get you down

https://reviewboard.mozilla.org/r/179304/#review184444

Great catch!
Attachment #8907625 - Flags: review?(alessio.placitelli) → review+
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31078c9f49c1
Don't let off-thread CCs get you down r=Dexter
https://hg.mozilla.org/mozilla-central/rev/31078c9f49c1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.