height of sanitize dialog is strangely affected by expanding the list of options

ASSIGNED
Assigned to

Status

Thunderbird
Preferences
ASSIGNED
3 months ago
3 months ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
In the Tools->Clear recent history dialog. If you expand the list of options via the arrow button, then close it and reopen again, you get high empty space below the lost of options. The dialog is not resized correctly.

Notice Firefox has the same bug (in History menu).
If FF has the same bug, we should report it there or ask Richard.
Flags: needinfo?(richard.marti)
(Assignee)

Comment 2

3 months ago
Created attachment 8906301 [details] [diff] [review]
1398467.patch

So my proposal is to only expand the dialog when the preferences list is shown. When it is collapsed, the list is only hidden, but dialog not shrunken.
This also applies to the "Everything" value in the time range list.
Please play with this a bit.
If the list of preferences is shown and the dialog closed, upon reopen the list is shown again.
This new version still has a bug that if the list is not shown but the dialog is reopened, the space for the list is already allocated. (Notice Firefox does not persist the closed state.)
This wasn't the case before the patch. So just tell me if this is the right direction and I should continue hunting that bug :)
Attachment #8906301 - Flags: feedback?(richard.marti)
Comment on attachment 8906301 [details] [diff] [review]
1398467.patch

At least on Windows, the dialog doesn't expand when I the first time open the list or I select "Everything". This makes the list/buttons move out of the dialog.

So the old dialog works better for me as I always can access all elements, also when it looks weird after some manipulations.

Have you also changed the default from "Everything" to "Last Hour"?

What about make the dialog a fixed height to show the menulist, the listbox and the buttons. The listbox can be hidden but the dialog soesn't shrink. When "Everything" is chosen and the user hovers over the "Clear now" button the warning is shown as a popup.
Attachment #8906301 - Flags: feedback?(richard.marti) → feedback-
Yes, FX is affected too and I think I saw a bug but can't find it now.
Flags: needinfo?(richard.marti)
Bug 1383592 is about some spacing issues where the buttons move off the panel.
You need to log in before you can comment on or make changes to this bug.