13985 - xpinstall does not return error code when error occurs

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Sean Su]

xpinstall does not return error code when error occurs before calling
StartInstall().

I needs to return an error code or some type so the native installers can detect
the error and respond appropriately.

Comment 1

[Cathleen]

needs to be fixed by beta

Comment 2

[Sean Su]

reassigning to myself.

Comment 3

[Daniel Veditz [:dveditz]]

This is fixed in the M10 build, if the script does not call Finalize or Abort
then SCRIPT_ERROR value is returned.

Comment 4

[Jimmy Lee]

Build 1999-10-18-09-M11(WIN), 1999-10-18-12-M11(MAC), 1999-10-18-08-M11(LINUX)

Installation of the file (all platforms) is still occuring with the following
script:

var regName = "13985";
var jarSrc = "smrtupdt.txt";

startInstall("Bug: 13985", "13985", "1.0.1.4", 0);
f = getFolder("Program", "13985");
addFile("Bug_13985", "1.0.1.41", jarSrc, f, jarSrc, true);
//Finalize intentionally omitted

The file is not getting registered.  The Install.log returns the following:
---------------------------------------------------------------------------
http://jimbob/jars/13985.xpi     --     10/18/1999 17:20:49
---------------------------------------------------------------------------

     Bug: 13985
     ----------


     Install **FAILED** with error -229
     Finished Installation  10/18/1999 17:20:52

This xpi file is at http://jimbob/jars/13985.xpi

EXPECTED RESULT:
File does not get installed.

Comment 5

[leger]

Clearing FIXED resolution due to reopen.

Comment 6

[Daniel Veditz [:dveditz]]

This bug is fixed, a status code is returned if the script does nothing.
Cleaning up after itself is another story entirely, and that's covered by bug
11581

Comment 7

[Jimmy Lee]

Build 1999-11-08-09-M11(WIN), 1999-11-08-08-M11(MAC), 1999-11-08-08-M11(LINUX)

Marking Verified.

Comment 8

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine

Comment 9

[David Epstein]

Moving test file 13985.xpi from /jimbob/jars to /jimbob/bugs folder.