Closed
Bug 1398549
Opened 7 years ago
Closed 7 years ago
'Title Bar' and 'Drag Space' checkbox labels in customization mode are impossible to read in dark theme
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | verified |
firefox58 | --- | verified |
People
(Reporter: euthanasia_waltz, Assigned: dao)
References
Details
(Keywords: nightly-community, regression, Whiteboard: [reserve-photon-structure])
Attachments
(2 files)
mozregression: 5:36.64 INFO: Last good revision: 6ee4de08ac3767c4d15338f830dc3763d5da769a 5:36.64 INFO: First bad revision: 563cbdd108d601c788b6d9b32092a6244ab7dc7f 5:36.64 INFO: Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6ee4de08ac3767c4d15338f830dc3763d5da769a&tochange=563cbdd108d601c788b6d9b32092a6244ab7dc7f caused by bug 1396975
Blocks: 1396975
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true
Keywords: nightly-community,
regression
Comment 2•7 years ago
|
||
Great, thank you! (For the record, we discussed that it's probably best to adjust all footer items to dark mode, which will fix the reported bug as well).
Updated•7 years ago
|
Priority: -- → P3
Summary: 'Title Bar' checkbox label in customization mode with Dark theme is hard to read → 'Title Bar' checkbox label in customization mode with Dark theme is impossible to read
Whiteboard: [reserve-photon-structure]
Updated•7 years ago
|
Summary: 'Title Bar' checkbox label in customization mode with Dark theme is impossible to read → 'Title Bar' and 'Drag Space' checkbox labels in customization mode are impossible to read in dark theme
Assignee | ||
Comment 4•7 years ago
|
||
I think we should just fix this regression. A redesign should be a separate bug, which may or may not make it into 57.
Comment 5•7 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #4) > I think we should just fix this regression. A redesign should be a separate > bug, which may or may not make it into 57. FWIW, I concur. Just making the checkbox text color white (or whatever the default foreground color is) in the cases where the background is black should work in the short-term, right?
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(abenson)
Priority: P3 → P1
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8908059 [details] Bug 1398549 - Let the 'Title Bar' and 'Drag Space' checkboxes inherit the text color when a lightweight theme is applied. https://reviewboard.mozilla.org/r/179768/#review184972 Thanks!
Attachment #8908059 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b24b96e6f8a1 Let the 'Title Bar' and 'Drag Space' checkboxes inherit the text color when a lightweight theme is applied. r=Gijs
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: gwimberly
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b24b96e6f8a1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
Iteration: --- → 57.3 - Sep 19
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Comment 10•7 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 Build ID: 20170921220243 This issue has been verified on latest Firefox Nightly Build ID: 20170921220243 on Windows 8.1 x64, Mac OS 10.12 and Ubuntu 14.04 and I cannot reproduce it. Now, the checkboxes from the bottom of the Customization page inherit the text color when a lightweight theme is applied.
Assignee | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
status-firefox58:
--- → verified
Comment 11•7 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID: 20170928180207 This issue has been verified on latest Firefox Beta 57.0b4 on Windows 8.1 x64, Mac OS 10.12 and Ubuntu 14.04 and I cannot reproduce it.
Updated•7 years ago
|
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•