1398621 - Bookmark icon changes temporarily when switching between customize mode and another tab

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Mohammad Maruf Rahman]

Attachment: bookmark-icon-change-bug.mp4

Build ID  : 20170910100150
user Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 
            Firefox/57.0
OS        : Windows 7 , 64 Bit

Steps to Reproduce : 

1. Open Firefox Nightly 
2. Open Customization and enable bookmark toolbar
3. Make sure you have another tab opened beside customization

Actual Result      : If I switch from customization tab to the other tab, the icon 
                     of "Get Involved" bookmark first changes to a glob icon, then 
                     changes to M icon(original icon)

Expected Result    : The icon of "Get Involved" bookmark should have been the 
                     original one, not a globe icon.

** It maybe related to   Bug 1395596

Comment 1

[:Gijs (he/him)]

I expect this regressed in bug 1392081.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

There is a delay before we set the button image, that allows us to save on memory and performance.
I consider this an edge case, in any case it may also be visible when opening a window afaict.

I'm not sure it's worth fixing it, since that would require calculating synchronously the state of each button, that will introduce synchronous layout flushes, that would just make things slower.

My opinion is that this is a wontfix.
Happy to listen to alternative opinions if they present possible approaches to solve the problem that don't involve introducing performance problems just to avoid a brief flicker in rare cases.