Closed Bug 1398628 Opened 7 years ago Closed 7 years ago

Remove VIDEO_CDM_CREATED telemetry

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: cpearce, Assigned: JamesCheng)

Details

Attachments

(1 file)

I got the following telemetry expiry warning today:

* VIDEO_CDM_CREATED expires in version 58.0a1 (watched by cpearce@mozilla.com) - Note the type of CDM (0=ClearKey, 1=Primetime, 2=Widevine, 3=unknown) every time we successfully instantiate an EME MediaKeys object.

We added this probe to determine whether it was safe to remove Primetime. We have since removed Primetime. So we no longer need this probe.

We should remove the VIDEO_CDM_CREATED telemetry probe.
James: Can you take this please?
Flags: needinfo?(jacheng)
Sure, 
Thanks.
Flags: needinfo?(jacheng)
Attachment #8906451 - Flags: review?(francois)
Attachment #8906451 - Flags: review?(cpearce)
Comment on attachment 8906451 [details]
Bug 1398628 - Remove VIDEO_CDM_CREATED telemetry and the related code.

https://reviewboard.mozilla.org/r/178178/#review183142

I don't think you need a datareview to _remove_ telemetry probes, but looks good to me.
Attachment #8906451 - Flags: review?(francois) → review+
Thank you, I'm just not sure if I should do the review for removing.
Comment on attachment 8906451 [details]
Bug 1398628 - Remove VIDEO_CDM_CREATED telemetry and the related code.

https://reviewboard.mozilla.org/r/178178/#review183540

Thanks!
Attachment #8906451 - Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d5aba559d56
Remove VIDEO_CDM_CREATED telemetry and the related code. r=cpearce,francois
https://hg.mozilla.org/mozilla-central/rev/8d5aba559d56
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.