Remove raw key fields from cipher specs

RESOLVED FIXED in Future

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: mt, Assigned: mt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
All cipher specs currently have a field for storing the master secret outside of PKCS#11 called msItem.  This field has a lot of code around it, but that code is never actually used (maybe it was once).  That code can all go.
(Assignee)

Comment 1

10 months ago
Hmm, I should rename this to reflect that it's not everything that I'm removing, only the SECItem stuff.  I discovered that the code doesn't even reference ssl3KeyMaterial.write_key_item and the other _key_item fields, so they are going too.

https://phabricator.services.mozilla.com/D46
Assignee: nobody → martin.thomson
Summary: Remove unused fields from cipher specs → Remove raw key fields from cipher specs
Priority: -- → P2
Comment on attachment 8906436 [details]
Bug 1398647 - Remove the SECItems used for "storing" keys in cipher specs, r?ttaubert

Tim Taubert [:ttaubert] has approved the revision.

https://phabricator.services.mozilla.com/D46#2652
Attachment #8906436 - Flags: review+
(Assignee)

Comment 3

9 months ago
https://hg.mozilla.org/projects/nss/rev/4093ae8b787b968ffe85787049e88c5b86d9bfcc
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.