Closed Bug 1398649 Opened 7 years ago Closed 7 years ago

Investigate why the SQLite syntax error doesn't trigger nserror during migration

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: tt, Assigned: tt)

References

Details

Attachments

(1 file)

Please refer to Bug 1398043. The SQLite syntax during a migration should abort the migration. However, it doesn't, so file this bug to investigate why and fix it.
The reason is that I forgot to get the error result when executing MigrateFrom25To26 [1]. Really sorry for that...

[1] http://searchfox.org/mozilla-central/source/dom/cache/DBSchema.cpp#3187
Comment on attachment 8906497 [details]
Bug 1398649: Capture the result from MigrateFrom25To26().

https://reviewboard.mozilla.org/r/178264/#review183262

Ah, ok.  So the schema verison number was being updated even though this one statement failed.  That makes sense.  Thanks for tracking it down!
Attachment #8906497 - Flags: review?(bkelly) → review+
(In reply to Ben Kelly [:bkelly] from comment #4)
> Comment on attachment 8906497 [details]
> Bug 1398649: Capture the result from MigrateFrom25To26().
> 
> https://reviewboard.mozilla.org/r/178264/#review183262
> 
> Ah, ok.  So the schema verison number was being updated even though this one
> statement failed.  That makes sense.  Thanks for tracking it down!

Thanks for the review!
Pushed by ttung@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad946b2319fc
Capture the result from MigrateFrom25To26(). r=bkelly
https://hg.mozilla.org/mozilla-central/rev/ad946b2319fc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.