1398773 - Dimensions from the active tab doesn't match as spec.

Status: RESOLVED INVALID

(Firefox :: Theme, defect, P4)

Description

[Valentina Claudia Ona]

Attachment: Dimensions ­ Tab active.bmp

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID:  20170910220126

[Affected versions]:  Nightly 57.0a1

[Affected platforms]:  Windows 8.1 x64

[Steps to reproduce]:
1.Launch Nightly 57.0a1 with a new profile.
2. Open a new tab.

[Expected result]:
The dimensions match as specifications.

[Actual result]:
The dimensions doesn't match as specifications.

[Notes]:
1. Please verify the attachment. 
2. What is not correct is marked with yellow.

Comment 1

[ovidiu boca[:Ovidiu]]

Also on Windows 7, the close button from the tab doesn't have the expected dimension of 16px, it has approximately 11px.

Comment 2

[Dão Gottwald [:dao]]

Valentina, is this limited to Windows 8.1? Windows 10, Linux and Mac are unaffected? Could you please attach a side-by-side screenshot of what you're seeing vs. the mockup? The yellow circles alone aren't very helpful.

Comment 3

[Valentina Claudia Ona]

Attachment: tab active.bmp

I attached other screenshot with actual results on Ubuntu 16.04, Mac OS 10.10, Windows 8.1 64x and  Windows 10 x64 and the specifications.

Comment 4

[Dão Gottwald [:dao]]

Thanks

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Bug 1398773 - Fix close icon margin from end of tab.

Review commit: https://reviewboard.mozilla.org/r/201672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201672/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8930543 [details]
Bug 1398773 - Fix close icon margin from end of tab.

https://reviewboard.mozilla.org/r/201672/#review206952

::: browser/themes/shared/tabs.inc.css:360
(Diff revision 1)
>    margin-inline-end: 0;
>    margin-inline-start: 0;
>  }
>  
>  .tab-close-button {
> -  margin-inline-end: -2px;
> +  margin-inline-end: -1px;

This would make the tab consume another pixel at its minimum width and require bumping browser.tabs.tabMinWidth to compensate that. Not really sure that we want this. See the discussion in bug 1406478 for some background.

Have you found the cause for the platform differences in attachment 8910214 [details]?

Comment 7

[Dale Harvey (:daleharvey)]

Tried to go through these on all platforms, either some things have changed or I am not understanding how these things were measured, a lot of them are referring to invisible borders (the space between the favicon and title seems to miss the 2px margin of the favicon) the right margin of the close was consistently off by 1 compared to the spec though

Comment 8

[Dão Gottwald [:dao]]

So just to be clear, you couldn't find any platform differences?

Comment 9

[Dale Harvey (:daleharvey)]

The space between the close icon background and the right of the tab is 7px on all platforms, the favicon is 16x16 everywhere, close icon 20x20 everywhere

The only platform difference I found was on ubuntu the space between the favicon is 7px compared to 6px on other platforms, its given exactly the same CSS with margin-inline-end: 6px (https://searchfox.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#151) so it feels like a rendering issue, I have seen text on ubuntu seems to start 1px off sometimes 

So if we dont want to change the end margin here then seems like this is closed invalid?

Comment 10

[Dão Gottwald [:dao]]

Sounds good. Thanks for investigating.