Closed
Bug 1398773
Opened 7 years ago
Closed 7 years ago
Dimensions from the active tab doesn't match as spec.
Categories
(Firefox :: Theme, defect, P4)
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox57 | --- | affected |
People
(Reporter: valentina.ona, Assigned: daleharvey)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(3 files)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170910220126
[Affected versions]: Nightly 57.0a1
[Affected platforms]: Windows 8.1 x64
[Steps to reproduce]:
1.Launch Nightly 57.0a1 with a new profile.
2. Open a new tab.
[Expected result]:
The dimensions match as specifications.
[Actual result]:
The dimensions doesn't match as specifications.
[Notes]:
1. Please verify the attachment.
2. What is not correct is marked with yellow.
Comment 1•7 years ago
|
||
Also on Windows 7, the close button from the tab doesn't have the expected dimension of 16px, it has approximately 11px.
Updated•7 years ago
|
Priority: -- → P3
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Updated•7 years ago
|
Priority: P3 → P4
Comment 2•7 years ago
|
||
Valentina, is this limited to Windows 8.1? Windows 10, Linux and Mac are unaffected? Could you please attach a side-by-side screenshot of what you're seeing vs. the mockup? The yellow circles alone aren't very helpful.
Flags: needinfo?(valentina.ona)
Reporter | ||
Comment 3•7 years ago
|
||
I attached other screenshot with actual results on Ubuntu 16.04, Mac OS 10.10, Windows 8.1 64x and Windows 10 x64 and the specifications.
Flags: needinfo?(valentina.ona) → needinfo?(dao+bmo)
Updated•7 years ago
|
Flags: qe-verify?
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
Updated•7 years ago
|
QA Contact: ovidiu.boca
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dharvey
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8930543 [details]
Bug 1398773 - Fix close icon margin from end of tab.
https://reviewboard.mozilla.org/r/201672/#review206952
::: browser/themes/shared/tabs.inc.css:360
(Diff revision 1)
> margin-inline-end: 0;
> margin-inline-start: 0;
> }
>
> .tab-close-button {
> - margin-inline-end: -2px;
> + margin-inline-end: -1px;
This would make the tab consume another pixel at its minimum width and require bumping browser.tabs.tabMinWidth to compensate that. Not really sure that we want this. See the discussion in bug 1406478 for some background.
Have you found the cause for the platform differences in attachment 8910214 [details]?
Attachment #8930543 -
Flags: review?(dao+bmo) → review-
Assignee | ||
Comment 7•7 years ago
|
||
Tried to go through these on all platforms, either some things have changed or I am not understanding how these things were measured, a lot of them are referring to invisible borders (the space between the favicon and title seems to miss the 2px margin of the favicon) the right margin of the close was consistently off by 1 compared to the spec though
Comment 8•7 years ago
|
||
So just to be clear, you couldn't find any platform differences?
Assignee | ||
Comment 9•7 years ago
|
||
The space between the close icon background and the right of the tab is 7px on all platforms, the favicon is 16x16 everywhere, close icon 20x20 everywhere
The only platform difference I found was on ubuntu the space between the favicon is 7px compared to 6px on other platforms, its given exactly the same CSS with margin-inline-end: 6px (https://searchfox.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#151) so it feels like a rendering issue, I have seen text on ubuntu seems to start 1px off sometimes
So if we dont want to change the end margin here then seems like this is closed invalid?
Comment 10•7 years ago
|
||
Sounds good. Thanks for investigating.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•