1398779 - If the Highlights section is re-enabled, no cards are displayed until the page is refreshed

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: highlights not displayed after re-enabling them.gif

[Affected versions]:
- Firefox 57.0a1 Build ID 20170910220126

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- browser.newtabpage.activity-stream.enabled is set to true in about:config on a clean new profile.
- Have enough history so that Top Sites and Highlights are populated.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites.
2. Click the "Customize your New Tab page" button.
3. Disable the Highlights section.
4. Re-enable the Highlights section.

[Expected results]:
- All previously hidden Highlights are displayed.

[Actual results]:
- Three empty placeholders are displayed.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3451 to be uplifted via bug 1399607.

Comment 2

[Marius Coman [:mcoman], Ecosystem QA, PTO until 20th of October, for any testing requests ping :poiegas]

The Highlights card are displayed if the Highlights section is re-enabled.
Verified as fixed using latest Nightly 57.0a1 Build ID 20170915100121, on Windows 10 x64 and Mac 10.12.