Closed Bug 1398839 Opened 8 years ago Closed 7 years ago

DataView getters should throw when the underlying buffer is detached in release/beta

Categories

(Core :: JavaScript: Standard Library, defect, P3)

Product:
Core
Component:
JavaScript: Standard Library
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: evilpies, Assigned: evilpies)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

DataView getters should throw when the buffer is detached in release/beta. r?
2.18 KB, patch
anba
: review+
Details | Diff | Splinter Review
In Bug #1317394 I only made DataView.prototype.byteLength and byteOffset throw in Nightly.
Priority: -- → P3
Assignee: nobody → evilpies
Comment on attachment 8987298 [details] [diff] [review] DataView getters should throw when the buffer is detached in release/beta. r? I actually forgot about this. I haven't heard of any regression caused by this change on beta/nightly so let's just ride it the trains.
Attachment #8987298 - Flags: review?(andrebargull)
Comment on attachment 8987298 [details] [diff] [review] DataView getters should throw when the buffer is detached in release/beta. r? Review of attachment 8987298 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8987298 - Flags: review?(andrebargull) → review+
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c907970edec DataView getters should throw when the buffer is detached in release/beta. r=anba
https://hg.mozilla.org/mozilla-central/rev/7c907970edec
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: