Closed
Bug 1398880
Opened 7 years ago
Closed 7 years ago
Implement the new photon syntax colors for the inspector and debugger
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
18.08 KB,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8906916 [details] Bug 1398880 - Implement the new photon font and syntax colors for the inspector and debugger. https://reviewboard.mozilla.org/r/178646/#review183658 I tested this locally and I think it looks good. If there are adjustments to be made, they can be made in follow-ups and uplifted. I have 3 comments: - The style editor syntax colors are different from the rule-view syntax colors, but both are for CSS code. Should we align? - I don't understand CodeMirror much, and so I only skimmed through the CSS changes for this. It looked like minor enough changes for R+. - The font-size in the debugger editor is smaller that everywhere else in DevTools. I know we had noted this as an inconsistency a long time ago already. Do you think we could address this here at the same time?
Attachment #8906916 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8906916 -
Attachment is obsolete: true
Attachment #8907194 -
Flags: review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/246cba2233e3 Implement the new photon font and syntax colors for the inspector and debugger. r=pbro
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/246cba2233e3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•