Closed Bug 1398885 Opened 2 years ago Closed 2 years ago

Extend APZ telemetry probes expiring in 58

Categories

(Core :: Panning and Zooming, defect, P3)

57 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

The following histograms will be expiring on 2017-09-20, and should be removed from the codebase, or have their expiry versions updated:

* CHECKERBOARD_DURATION expires in version 58.0a1 (watched by kgupta@mozilla.com) - Duration of a checkerboard event in milliseconds
* CHECKERBOARD_PEAK expires in version 58.0a1 (watched by kgupta@mozilla.com) - Peak number of CSS pixels checkerboarded during a checkerboard event (the high value is the size of a 4k display with max APZ zooming)
* CHECKERBOARD_POTENTIAL_DURATION expires in version 58.0a1 (watched by kgupta@mozilla.com) - Duration of a chunk of time (in ms) that could reasonably have had checkerboarding
* CHECKERBOARD_SEVERITY expires in version 58.0a1 (watched by kgupta@mozilla.com) - Opaque measure of the severity of a checkerboard event
* COMPOSITOR_ANIMATION_DURATION expires in version 58.0a1 (watched by kgupta@mozilla.com) - Duration of animations running on the compositor in milliseconds
* COMPOSITOR_ANIMATION_MAX_LAYER_AREA expires in version 58.0a1 (watched by kgupta@mozilla.com) - High-watermark of layer area affected during a compositor animation. Units are layer pixels squared.
* CONTENT_RESPONSE_DURATION expires in version 58.0a1 (watched by kgupta@mozilla.com) - Main thread response times for APZ notifications about input events (ms)

This is an automated message sent by Cerberus. See https://github.com/mozilla/cerberus for details and source code.
I think we want all of these except possibly CONTENT_RESPONSE_DURATION to be extended. We should look at CONTENT_RESPONSE_DURATION to see if the numbers are stable and if the content response timeout needs any final tweaking.
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Whiteboard: [gfx-noted]
So for CONTENT_RESPONSE_DURATION, the duration values have been decreasing since Nightly 53: https://mzl.la/2gZ8HsL
The latest data shows the 99th percentile value is ~167ms on desktop and ~380ms on mobile. The current values for the prefs are 400ms and 600ms respectively (chosen in bug 1247280), so it looks like we can bring those down a bit and still maintain 99% accuracy.

In terms of the probe expiry, I think given that these values have shifted over the past few releases I'd like to extend the probe a few more releases to see what happens.
Comment on attachment 8906773 [details]
Bug 1398885 - Extend various APZ telemetry probes out for a few more releases. , data-r?liuche

Manually adding r?liuche for data collection review since MozReview didn't seem to pick that up.
Attachment #8906773 - Flags: review?(liuche)
Comment on attachment 8906773 [details]
Bug 1398885 - Extend various APZ telemetry probes out for a few more releases. , data-r?liuche

https://reviewboard.mozilla.org/r/178496/#review183524
Attachment #8906773 - Flags: review?(botond) → review+
Comment on attachment 8906773 [details]
Bug 1398885 - Extend various APZ telemetry probes out for a few more releases. , data-r?liuche

https://reviewboard.mozilla.org/r/178496/#review184104

datareview+, extending duration of type 2 data probes
Attachment #8906773 - Flags: review?(liuche) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8244494f5906
Extend various APZ telemetry probes out for a few more releases. r=botond, data-r=liuche
https://hg.mozilla.org/mozilla-central/rev/8244494f5906
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.