Closed Bug 1398890 Opened 3 years ago Closed 3 years ago

Use the same number of chunks for reftest-gpu as other Windows reftests

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla57

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

Right now, it runs in one chunk and as a result is the long pole in tests finishing up. Let's chunk it the same as the others.
Lots of hackery for debug thanks to scheduling via BBB still. Will be much simpler once bug 1398284 gets sorted out.

Green on Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0def15dc896dbcdd6065fe9ddd22a86f662f7be6
Attachment #8906746 - Flags: review?(jmaher)
Comment on attachment 8906746 [details] [diff] [review]
use 8 chunks for reftest-gpu like other Win7 reftests

Review of attachment 8906746 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/test/tests.yml
@@ +1170,5 @@
> +        chunked:
> +            # Remove special casing when debug isn't using BBB anymore
> +            by-test-platform:
> +                windows7-32.*/debug: false
> +                default: true

where is this chunked?  I see a single reftest-gpu job on win7 only; can we just say |chunked: false| ?
Attachment #8906746 - Flags: review?(jmaher) → review-
It's chunked on opt, see the Try push I linked to. Debug is un-chunked because it runs on BBB and I didn't want to go through the hassle of adding buildernames over it.
Flags: needinfo?(jmaher)
Comment on attachment 8906746 [details] [diff] [review]
use 8 chunks for reftest-gpu like other Win7 reftests

Review of attachment 8906746 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for clarifying this- I think it is a bit overkill to have small chunks given the ~2 minute overhead of the jobs for a <10 minute job, but we should keep things uniform where possible.
Attachment #8906746 - Flags: review- → review+
We definitely need to spend some time optimizing this all once the TC porting work is finished. We're definitely overkill on opt chunks right now, but for now I'll settle for parity across the different suites :)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f23262ca8871
Use 8 chunks for Windows reftest-gpu. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/f23262ca8871
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Flags: needinfo?(jmaher)
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.