1398965 - Fold memory/mozjemalloc into memory/build

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1398965 - Remove MOZ_JEMALLOC_IMPL in favor of MOZ_MEMORY_IMPL.

In practice, they mean the same thing, and there's only one place where
MOZ_JEMALLOC_IMPL was used.

Review commit: https://reviewboard.mozilla.org/r/178544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178544/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1398965 - Fold memory/mozjemalloc into memory/build.

The files relevant to the memory allocator are currently spread between
memory/mozjemalloc and memory/build, and the distinction was
historically from sharing some Mozilla-specific things between
mozjemalloc and jemalloc3. That distinction is not useful anymore, so
we fold everything together.

As we will likely rename the allocator at some point in the future, it
is preferable to move away from the mozjemalloc directory rather than in
its direction.

Review commit: https://reviewboard.mozilla.org/r/178546/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178546/

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8906827 [details]
Bug 1398965 - Remove MOZ_JEMALLOC_IMPL in favor of MOZ_MEMORY_IMPL.

https://reviewboard.mozilla.org/r/178544/#review183588

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8906828 [details]
Bug 1398965 - Fold memory/mozjemalloc into memory/build.

https://reviewboard.mozilla.org/r/178546/#review183594

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 9e1a2ae652e1 -d 114d87a3943b: rebasing 419323:9e1a2ae652e1 "Bug 1398965 - Remove MOZ_JEMALLOC_IMPL in favor of MOZ_MEMORY_IMPL. r=njn"
merging memory/mozjemalloc/moz.build
rebasing 419324:cda392397efa "Bug 1398965 - Fold memory/mozjemalloc into memory/build. r=njn" (tip)
local [dest] changed memory/mozjemalloc/moz.build which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8906827 [details]
Bug 1398965 - Remove MOZ_JEMALLOC_IMPL in favor of MOZ_MEMORY_IMPL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/178544/diff/1-2/

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8906828 [details]
Bug 1398965 - Fold memory/mozjemalloc into memory/build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/178546/diff/1-2/

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8906828 [details]
Bug 1398965 - Fold memory/mozjemalloc into memory/build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/178546/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7da983d68889
Remove MOZ_JEMALLOC_IMPL in favor of MOZ_MEMORY_IMPL. r=njn
https://hg.mozilla.org/integration/autoland/rev/77650b2c2812
Fold memory/mozjemalloc into memory/build. r=njn

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7da983d68889
https://hg.mozilla.org/mozilla-central/rev/77650b2c2812