1398966 - If javac is out of date, suggest to the user to check JAVA_HOME

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Botond Ballo [:botond]]

I recently tried to build Fennec, and was momentarily stumped by the error:

  ERROR: javac 1.8 or higher is required (found 1.7.0_151)

which surprised me because the "javac" in my PATH was 1.8.

The culprit was my JAVA_HOME environment variable, which was pointing to the older 1.7 Java installation.

I think it would be helpful if the error message contained a hint to check JAVA_HOME.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1398966 - Suggest checking JAVA_HOME if javac is out of date.

Review commit: https://reviewboard.mozilla.org/r/178540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178540/

Comment 2

[Botond Ballo [:botond]]

Heh, we actually have a test for the wording of the error message :)

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 8906826 [details]
Bug 1398966 - Suggest checking JAVA_HOME if javac is out of date.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/178540/diff/1-2/

Comment 4

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

Comment on attachment 8906826 [details]
Bug 1398966 - Suggest checking JAVA_HOME if javac is out of date.

https://reviewboard.mozilla.org/r/178540/#review183878

Thanks, botond!

Comment 5

[Mozilla Autoland]

hg error in cmd: hg update --clean -r ba1cf2c8ad66: abort: unknown revision 'ba1cf2c8ad66'!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07c36f901a06
Suggest checking JAVA_HOME if javac is out of date. r=nalexander

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/07c36f901a06