Closed
Bug 1398999
Opened 7 years ago
Closed 7 years ago
nsDequeFunctor::operator() doesn't need to return anything
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
Details
Attachments
(1 file)
nsDequeFunctor::operator() return void*, but this return value is never used; and most implementations return nullptr anyway. So it could just not return anything.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8906885 [details] Bug 1398999 - nsDequeFunctor::operator() doesn't need to return anything - https://reviewboard.mozilla.org/r/178618/#review183790 I guess we could have it return something to indicate that `ForEach` should stop iterating, but apparently clients are not consistent in their return values anyway. So this is a reasonable cleanup...as much as `nsDeque` can be cleaned up. Thanks!
Attachment #8906885 -
Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a96a71425be nsDequeFunctor::operator() doesn't need to return anything - r=froydnj
Assignee | ||
Comment 5•7 years ago
|
||
Thank you for the quick review Nathan.
> as much as `nsDeque` can be cleaned up.
I've got great plans for nsDeque, just you wait!
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1a96a71425be
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•