nsDequeFunctor::operator() doesn't need to return anything

RESOLVED FIXED in Firefox 57

Status

()

Core
XPCOM
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gerald, Assigned: gerald)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
nsDequeFunctor::operator() return void*, but this return value is never used; and most implementations return nullptr anyway.
So it could just not return anything.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

4 months ago
mozreview-review
Comment on attachment 8906885 [details]
Bug 1398999 - nsDequeFunctor::operator() doesn't need to return anything -

https://reviewboard.mozilla.org/r/178618/#review183790

I guess we could have it return something to indicate that `ForEach` should stop iterating, but apparently clients are not consistent in their return values anyway.  So this is a reasonable cleanup...as much as `nsDeque` can be cleaned up.

Thanks!
Attachment #8906885 - Flags: review?(nfroyd) → review+

Comment 4

4 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a96a71425be
nsDequeFunctor::operator() doesn't need to return anything - r=froydnj
(Assignee)

Comment 5

4 months ago
Thank you for the quick review Nathan.

> as much as `nsDeque` can be cleaned up.
I've got great plans for nsDeque, just you wait!
https://hg.mozilla.org/mozilla-central/rev/1a96a71425be
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.