Closed Bug 1399005 Opened 3 years ago Closed 3 years ago

Fix strict ordering of data and stop request events with cross-thread stream filters

Categories

(WebExtensions :: Request Handling, defect, P1)

defect

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

When data delivery is not on the same thread as the StreamFilterParent actor, it's sometimes possible for the OnStopRequest to be dispatched on the main thread before the last OnDataAvailable event has been processed on the IO thread, which causes issues for listeners that expect it to be otherwise.
Comment on attachment 8907197 [details]
Bug 1399005: Always dispatch OnStop from the IO thread.

https://reviewboard.mozilla.org/r/178870/#review183986
Attachment #8907197 - Flags: review?(mixedpuppy) → review+
Duplicate of this bug: 1399273
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/9a676cb6f09a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.