Closed Bug 1399039 Opened 7 years ago Closed 7 years ago

Crash in java.lang.IllegalStateException: Already registered URI_INSERTED_TO_HISTORY at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java)

Categories

(Firefox for Android Graveyard :: General, defect)

57 Branch
defect
Not set
critical

Tracking

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: calixte, Assigned: Grisha)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-d53ec244-fc60-49e2-ad90-06a6d0170912.
=============================================================

There are 44 crashes in nightly 57 (6 in 56.0a1 and 1 in 55.0a1).
:Grisha Kruglov, could you investigate please ?
Flags: needinfo?(gkruglov)
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Flags: needinfo?(gkruglov)
I haven't checked why this is spiking now (it's been around since 52, Bug 1301717).
Comment on attachment 8907364 [details]
Bug 1399039 - Don't initialize GlobalPageMetadata more than once

https://reviewboard.mozilla.org/r/179038/#review184272

::: mobile/android/base/java/org/mozilla/gecko/GlobalPageMetadata.java:74
(Diff revision 1)
>      private GlobalPageMetadata() {}
>  
>      public void init() {
> +        if (initialized) {
> +            return;
> +        }

This is a bit concerning. This method is called from GeckoApplication.onCreate() which should only be invoked once per process.
Attachment #8907364 - Flags: review?(s.kaspari) → review+
(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> This is a bit concerning. This method is called from
> GeckoApplication.onCreate() which should only be invoked once per process.

Yes. All other similarly initialized classes (see onCreate) do the same thing in their init methods. One of them vaguely mentions background services as the cause.
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34b7638b00c8
Don't initialize GlobalPageMetadata more than once r=sebastian
HardwareUtils is what I was referring to in Comment 4, and it is used from background services in a way that it will likely to get init'd multiple times. The others though, including GlobalPageMetadata, are only invoked from GeckoApplication's onCreate...
https://hg.mozilla.org/mozilla-central/rev/34b7638b00c8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.