[Form Autofill] - Credit Card doorhanger is not displayed properly and according to the mocks

VERIFIED FIXED in Firefox 57

Status

()

P2
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: Gabi, Assigned: steveck)

Tracking

Trunk
mozilla58
Points:
---

Firefox Tracking Flags

(firefox56 wontfix, firefox57 verified, firefox58 verified)

Details

(Whiteboard: [form autofill])

Attachments

(5 attachments)

Posted file MacOSdoorhanger.png
[Environment:]
Ubuntu 16.04, Mac Osx 10.13, Win10x64

Nightly 57.0a1 20170912013600



[Steps:]

Preconditions
Go to Preferences/ Privacy and Security / Form Autofill / Enable Profile autofill (default in Nightly)
Make sure you have at least one saved CC profile


1. Open Firefox
2. Go to credit card demo page
3. Fill in all the fields required
4. Click Submit button
5. When door hanger is displayed tap the middle arrow
6. Observe the "Never save credit cards" button


[Actual Result:]
Never save credit cards button is not displayed according to mock design, on Ubuntu the button is black and on MacOS the button is not aligned 
Credit card door hanger is not displayed at all on Win 10x64/Win 7x64


[Expected Result:]
Doorhanger and buttons should be displayed according to the mocks


[Note:]
This is a Not regression
Correction: Door hanger is displayed on Windows too, the value for month/year was added in the wrong format and form must have treat it as invalid and did not trigger the pop-up.Added attachment for door hanger UI for Win. Thanks
Flags: needinfo?(schung)
Whiteboard: [form autofill]
(Assignee)

Comment 5

2 years ago
Hi Fang, I think it's default doorhanger UI but I'm not quite sure if it's expected layout. Do you know where we can find the latest doorhanger visual spec for QA?
Flags: needinfo?(schung) → needinfo?(fshih)

Comment 6

2 years ago
Hi Steve, There is no update on doorhanger UI for Photon currently, so we should stick with what we have as default doorhanger UI for now.
We just need to make sure it is using the system doorhanger UI. We are not supposed to create a new layout for it. 
As for the dropdown button "Never Save Credit Card" > currently Firefox is using system UI for that part. so it depends on what system you are using. 

But I don't think we suppose to have x button on the right corner? is this default doorhanger UI? 

For the URL autofill icon, it still looks off position, have you update the icon and spec as we mentioned the other day?

Thanks.
Flags: needinfo?(fshih) → needinfo?(schung)
(Assignee)

Comment 7

2 years ago
(In reply to Fang Shih [:fang] from comment #6)
> Hi Steve, There is no update on doorhanger UI for Photon currently, so we
> should stick with what we have as default doorhanger UI for now.
> We just need to make sure it is using the system doorhanger UI. We are not
> supposed to create a new layout for it. 
> As for the dropdown button "Never Save Credit Card" > currently Firefox is
> using system UI for that part. so it depends on what system you are using.

Hi Gabi, could you please verify if the autofill doorhanger layout is the same as the password saving doorhanger? 
 
> 
> But I don't think we suppose to have x button on the right corner? is this
> default doorhanger UI? 

Yes that's default for doorhanger, but we can also hide the close button by setting display option.

> 
> For the URL autofill icon, it still looks off position, have you update the
> icon and spec as we mentioned the other day?

Bug 1397115 is created for it.
Flags: needinfo?(schung) → needinfo?(gasofie)
(In reply to Steve Chung [:steveck] from comment #7)
> (In reply to Fang Shih [:fang] from comment #6)
> Hi Gabi, could you please verify if the autofill doorhanger layout is the
> same as the password saving doorhanger? 

Verified and the autofill door hanger layout is as the layout for the password saving door hanger.

> But I don't think we suppose to have x button on the right corner? is this
> default doorhanger UI? 

There's no x button in the right corner in the visual mock screens: https://mozilla.invisionapp.com/share/7ZA4WEK9W#/screens/215537981
Flags: needinfo?(gasofie)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → schung
status-firefox56: --- → affected
status-firefox58: --- → affected

Comment 10

2 years ago
mozreview-review
Comment on attachment 8911101 [details]
Bug 1399065 - [Form Autofill] - Hide autofill doorhanger close button.

https://reviewboard.mozilla.org/r/182596/#review189052
Attachment #8911101 - Flags: review?(lchang) → review+
(Assignee)

Comment 11

2 years ago
Thanks! BTW do we need to uplift this one as well(since you highlight fx56 is affected)?
Flags: needinfo?(lchang)
Keywords: checkin-needed

Comment 12

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/96609bba12f3
[Form Autofill] - Hide autofill doorhanger close button. r=lchang
Keywords: checkin-needed

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/96609bba12f3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
(In reply to Steve Chung [:steveck] from comment #11)
> Thanks! BTW do we need to uplift this one as well(since you highlight fx56
> is affected)?

It should be uplifted to Fx57. For Fx56, however, I marked it "affected" just for a reminder but I actually think it doesn't need to (and can't) be uplifted as it's really a minor issue. On a second thought, I probably should mark it "wontfix".
status-firefox56: affected → wontfix
Flags: needinfo?(lchang)
Verified as fixed with 58.0a1 (2017-09-28) on Windows 10x64, Ubuntu 16.4 and MacOS 10.13
status-firefox58: fixed → verified
(Assignee)

Comment 16

2 years ago
Comment on attachment 8911101 [details]
Bug 1399065 - [Form Autofill] - Hide autofill doorhanger close button.

Approval Request Comment
[Feature/Bug causing the regression]: This issue is existed from the first day we introduced form autofill doorhanger in bug 1303510.
[User impact if declined]: Users could see the hide button on the doorhanger.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: It only changed the form autofill display option that hides the doorhanger's close button. 
[String changes made/needed]: N/A
Attachment #8911101 - Flags: approval-mozilla-beta?
Comment on attachment 8911101 [details]
Bug 1399065 - [Form Autofill] - Hide autofill doorhanger close button.

Improve the l&f of a new feature, taking it.
Should be in 57b5
Attachment #8911101 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 18

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/509179a59024
status-firefox57: affected → fixed
Verified fix on 57.0b5  Windows 10x64, Ubuntu 16.4 and MacOS 10.13
status-firefox57: fixed → verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.