Update more tests within dom/ to comply with new toplevel data: URI navigation policy

RESOLVED FIXED in Firefox 57

Status

()

Core
DOM: Security
P2
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
Beats me, but it seems not all tests run on Linux TRY. There tests within dom/ that only failed on Windows and or Android when pushing the pref for blocking toplevel data: URI navigations.
(Assignee)

Updated

2 months ago
Assignee: nobody → ckerschb
Blocks: 1380959
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
(Assignee)

Comment 1

2 months ago
Created attachment 8907017 [details] [diff] [review]
bug_1399074_more_dom_tests.patch

Smaug, sorry for the additonal work, but it seems not all tests run on Linux, hence I missed those tests to udpate in my other patch for dom/ tests. Hopefully I got them all this time around:

* dom/tests/mochitest/bugs/test_resize_move_windows.html
We are also setting security.data_uri.unique_opaque_origin, hence I think it's fine to also push the pref here explicitly.

* dom/browser-element/mochitest/test_browserElement_inproc_CopyPaste.html
* dom/browser-element/mochitest/test_browserElement_inproc_BrowserWindowResize.html
* dom/browser-element/mochitest/test_browserElement_inproc_Close.html
* dom/browser-element/mochitest/test_browserElement_inproc_ContextmenuEvents.html
* dom/browser-element/mochitest/test_browserElement_inproc_DataURI.html
* dom/browser-element/mochitest/test_browserElement_inproc_TopBarrier.html
For tests within browser-element I am pushing the pref within browserElementTestHelpers. Would you be fine with that change. It seems rewriting all of those tests would require quite some effort.
Attachment #8907017 - Flags: review?(bugs)

Comment 2

2 months ago
Comment on attachment 8907017 [details] [diff] [review]
bug_1399074_more_dom_tests.patch

Hmm, we do need proper tests for mozbrowser.
There has been some talk to expose the functionality to webextensions and at least at some point devtools wanted to use mozbrowser.

If you write some explicit test checking that data: loads work the expected ways in mozbrowsers, then we can take this.
Attachment #8907017 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

2 months ago
(In reply to Olli Pettay [:smaug] from comment #2)
> If you write some explicit test checking that data: loads work the expected
> ways in mozbrowsers, then we can take this.

I filed Bug 1399170 to do so.
Blocks: 1399170

Comment 4

2 months ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be5bcc9e9657
Update more tests within dom/ to comply with new toplevel data: URI navigation policy. r=smaug
https://hg.mozilla.org/mozilla-central/rev/be5bcc9e9657
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.