Closed Bug 1399082 Opened 2 years ago Closed 2 years ago
Placeholder string incorrectly reused for all Sections
In bug 1392230 there was allSections string added, https://hg.mozilla.org/mozilla-central/rev/2906056b9833 The string is used as a placeholder in other string but the change fails to even suggest that. Whats more the "Find in [(single named section) or (all sections)]" doesn't work at all with Polish grammar (and probably others).
The context of the string is: "Find in all sections" is the placeholder text in the top-right search field on about:telemetry when the Home section is displayed. For other sections, the section name is used so that it reads some string like "Find in Environment" -- What would be a good string/treatment for this sort of situation? Preferences uses "Find in Preferences" but "Find in about:telemetry" doesn't quite work, "Find in Telemetry" isn't correct (as Telemetry is the whole system), "Find in Your Data" sounds like it would have more grammar (and legal?) repercussions... I'm at a loss.
The problem is reusing "all sections" in two different roles (object, ablative). Something like this should work. # LOCALIZATION NOTE (filterSectionPlaceholder): %S is a section name (General # Data, etc.). String is used as a placeholder in the search input field. filterSectionPlaceholder = Find in %S filterAllPlaceholder = Find in all sections # LOCALIZATION NOTE (filterAllPlaceholder): %1$S is a section name, %2$S is # replaced by the searched terms. noSearchResultsSection = Sorry! There are no results in %1$S for “%2$S” # LOCALIZATION NOTE (noSearchResultsAll): %S is replaced by the searched # terms. noSearchResultsAll = Sorry! There are no results in all sections for “%S”
(In reply to Francesco Lodolo [:flod] from comment #2) > # LOCALIZATION NOTE (filterSectionPlaceholder): %S is a section name (General > # Data, etc.). String is used as a placeholder in the search input field. > filterSectionPlaceholder = Find in %S > filterAllPlaceholder = Find in all sections Exactly what Flod suggests.
Comment on attachment 8907226 [details] bug 1399082 - about:telemetry l10n fixes https://reviewboard.mozilla.org/r/178866/#review184252 This works, thanks. On a more general note, it would be great to clean up the file and start using the format normally used in other .properties files for localization notes.
Attachment #8907226 - Flags: review?(francesco.lodolo) → review+
(In reply to Francesco Lodolo [:flod] from comment #2) > # LOCALIZATION NOTE (noSearchResultsAll): %S is replaced by the searched > # terms. > noSearchResultsAll = Sorry! There are no results in all sections for “%S” One small thing, should this be "there are no results in any sections"? (non-native speaker here, so not 100% sure)
(In reply to Georg Fritzsche [:gfritzsche] from comment #6) > One small thing, should this be "there are no results in any sections"? > (non-native speaker here, so not 100% sure) Good point, I was only looking at recreating the original sentences. (resetting assignee)
Assignee: splewako → chutten
It depends whether you think of "All Sections" as a noun phrase that has meaning or as just a couple of words. I've made the change, though, as I was wondering about it myself. As for translating to modern .properties format and norms, is there a document detailing what they are? Or is there a file that proves a particularly good example to follow? I've filed bug 1399456 to track the work. :flod, could you add your input there?
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b061a65e51d7 about:telemetry l10n fixes r=flod
Backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=130697447&repo=autoland https://hg.mozilla.org/integration/autoland/rev/e392e524801b35ed775377015c48301416c2192e
Fancy quotes? I'll get those in there.
I assumed you copied the existing string, didn't pay attention to the straight quotes :-\ noSearchResultsAll = Sorry! There are no results in any sections for “%S” Sorry about that.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/6c8fd74d8dcf about:telemetry l10n fixes r=flod
You need to log in before you can comment on or make changes to this bug.