processHang.button_stop.label string incorrectly reused for processHang.add-on.*

REOPENED
Unassigned

Status

()

Toolkit
WebExtensions: Frontend
P3
normal
REOPENED
a month ago
a month ago

People

(Reporter: stef, Unassigned)

Tracking

57 Branch
Points:
---

Firefox Tracking Flags

(firefox57 affected)

Details

(Reporter)

Description

a month ago
It is not OK and safe to reuse strings like below.

https://hg.mozilla.org/mozilla-central/diff/b83aea215a82/browser/locales/en-US/chrome/browser/browser.properties
> processHang.label = A web page is slowing down your browser. What would you like to do?
>+# LOCALIZATION NOTE (processHang.add-on.label): The first %S is the name of
>+# an extension. The second %S is the name of the product (e.g., Firefox)
>+processHang.add-on.label = A script in the extension "%S" is causing %S to slow down.
>+processHang.add-on.learn-more.text = Learn more
>+processHang.add-on.learn-more.url = https://support.mozilla.org/en-US/kb/warning-unresponsive-script?cache=no#w_other-causes
> processHang.button_stop.label = Stop It
> processHang.button_stop.accessKey = S
> processHang.button_wait.label = Wait
> processHang.button_wait.accessKey = W
> processHang.button_debug.label = Debug Script
> processHang.button_debug.accessKey = D

It may work for English but we need translate differently processHang.button_stop.label for addon/extension/web page/ ("Zatrzymaj ją" vs "Zatrzymaj go").

Updated

a month ago
Priority: -- → P3
You may need to translate it differently for addon/extension/web page, by why do you need to translate it differently for "script" which is the subject of both messages?

In any case, these strings are only used in non-e10s mode, which is being phased out. As long as the basic functionality works, the exact details don't matter very much.
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → WONTFIX
Sorry, I don't think this should be a WONTFIX, at least until I have a few details clearer.

> You may need to translate it differently for addon/extension/web page, by
> why do you need to translate it differently for "script" which is the
> subject of both messages?

If I understand correctly, the "Stop it" button is used for both processHang.label and processHang.add-on.label. The button was originally introduced for processHang.label, and there the subject is "web page", not "script".

So, the button in Italian is "Bloccala" (because webpage is female), but now it refers to script, and it should be "Bloccalo". In other words, we likely broke a few languages in bug 1391933.

> In any case, these strings are only used in non-e10s mode, which is being
> phased out. As long as the basic functionality works, the exact details
> don't matter very much.

I assume processHang.label (webpage) is the one that's going away? 

If that's the case, we need a new set of buttons used only for the new add-on string (subject: script).

processHang.add-on.button_stop.label = Stop It
processHang.add-on.button_stop.accessKey = S
processHang.add-on.button_wait.label = Wait
processHang.add-on.button_wait.accessKey = W
(the debug script button should be safe)

And once e10s is the only option, drop the old strings.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
You need to log in before you can comment on or make changes to this bug.