1399141 - Tell JS engine about malloc memory when binding object created

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Jon Coppeard (:jonco)]

Following on from bug 1301863 we should inform the JS engine about malloc memory when binding objects are created for the other cases where we currently call JS_updateMallocMemory().

This should give the JS engine a better idea of how much malloc memory is tied to JS objects and allow for better GC scheduling decisions.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1399141-update-malloc-count-on-binding

The patch does this for the classes CanvasRenderingContext2D and ImageBitmap.

I also changed the return type of BindingJSObjectMallocBytes() to size_t.

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8907110 [details] [diff] [review]
bug1399141-update-malloc-count-on-binding

Review of attachment 8907110 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/ImageBitmap.cpp
@@ +2123,5 @@
> +
> +  // Calculate how many bytes are used.
> +  if (mData->GetFormat() == mozilla::ImageFormat::PLANAR_YCBCR) {
> +    return mData->AsPlanarYCbCrImage()->GetDataSize();
> +  } else if (mData->GetFormat() == mozilla::ImageFormat::NV_IMAGE) {

I know that this is old code, but, no "} else {" after a return. Just do:

if (mData->GetFormat() == mozilla::ImageFormat::PLANAR_YCBCR) {
  return mData->AsPlanarYCbCrImage()->GetDataSize();
}

if (mData->GetFormat() == mozilla::ImageFormat::NV_IMAGE) {
  return mData->AsNVImage()->GetBufferSize();
}

RefPtr<SourceSurface> surface = mData->GetAsSourceSurface();
const int bytesPerPixel = BytesPerPixel(surface->GetFormat());
return surface->GetSize().height * surface->GetSize().width * bytesPerPixel;

Comment 3

[Naveed Ihsanullah [:naveed]]

Should we take it for FF57? Is it pretty safe? What is the perf impact?

Comment 4

[Jon Coppeard (:jonco)]

No perf impact.  I think this is safe to take.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff90282974ce
Attribute malloc memory when creating reflector object r=baku

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ff90282974ce