1399146 - Unbreak jprof and minor cleanup

Status: RESOLVED INCOMPLETE

(Core :: Gecko Profiler, enhancement, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Something broke building jprof recently; the fix is fairly simple (provide an moz_xalloc() wrapper).  In the process I did some very minor cleanup that had been waiting.

JPROF_REAL is still broken (as it has been for years, thanks Linux).  Cleopatra output disabled since it no longer works.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Unbreak jprof analysis and minor jprof cleanup

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 8907114 [details] [diff] [review]
Unbreak jprof analysis and minor jprof cleanup

r=dbaron; sorry for the delay

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1399146: Minor jprof cleanup r=dbaron NPOTB

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1399146: Have jprof output "perf script"-compatible profiles r=gerald

Depends on D35849

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Here's a profile taken with jprof of loading CNN. One thing we could do with jprof would be to turn on the gecko profiler in markers-only mode, and merge the stack from jprof with the markers from gecko (and get all the threads without the heavy overhead -- but without the script stack info - unless we can get it to use the data from --enable-perf). Generally the stacks appear better than what we get from perf, note.

https://perfht.ml/2FylTSN

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D35853	Bug 1399146: Have jprof output "perf script"-compatible profiles r=gerald	jesup	gerald: Resigned from review

:jesup, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit auto_nag documentation.