Update available doorhanger's "See what's new" link styling looks weird when brandShorterName == Firefox

RESOLVED FIXED in Firefox 57

Status

()

defect
P2
minor
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dthayer, Assigned: dthayer)

Tracking

55 Branch
mozilla58
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

Attachments

(4 attachments)

Posted image brokentext.PNG
I didn't notice this before, because in English, when brandShorterName is "Nightly", the wrapping works out to put "See what's new" on the same line as the text before it. However, when brandShorterName is "Firefox" (on Windows, with standard DPI), "See what's new" gets its own line, creating this weird formatting.
This is off due to the global margin rules for labels. We could override that, or put the link on its own line to match the styling of "Learn more" links in other doorhangers.

Bram, which option do you prefer? Should "See what's new" display in line or should it look like a "Learn more" link?
Flags: needinfo?(bram)
Posted image learnmore.PNG
Posted image seewhatsnew.PNG
I propose the latter option: don’t override the global rule, and give the “See what’s new” link its own line to match other doorhangers.
Flags: needinfo?(bram)
Comment on attachment 8910522 [details]
Bug 1399177 - Pull label out of description in update popups

https://reviewboard.mozilla.org/r/181950/#review187460

rs=me, I assume you've tested this. :-)
Attachment #8910522 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f81f645704e4
Pull label out of description in update popups r=Gijs
https://hg.mozilla.org/mozilla-central/rev/f81f645704e4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Doug, do you think this is worth uplifting to 57?
Flags: needinfo?(dothayer)
Hmm, it's a minor issue, but it's also not a very risky change, so I'd say yes.
Flags: needinfo?(dothayer)
Comment on attachment 8910522 [details]
Bug 1399177 - Pull label out of description in update popups

I think this should land for 57

Approval Request Comment
[Feature/Bug causing the regression]: Bug 893505
[User impact if declined]: The UI will look weird when there is a What's New link.
[Is this code covered by automated tests?]: No, this is a visual change
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: I don't think it is needed for this.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It is a styling change
[String changes made/needed]: None
Attachment #8910522 - Flags: approval-mozilla-beta?
Comment on attachment 8910522 [details]
Bug 1399177 - Pull label out of description in update popups

Small polish, taking it (but to be clear, as owner of the release notes, I am a  bit biased ;)
Should be in 57b3
Attachment #8910522 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #11)
> [Is this code covered by automated tests?]: No, this is a visual change
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: I don't think it is
> needed for this.

Setting qe-verify- based on Robert's assessment on manual testing needs.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.