1399180 - Select tool on mousedown rather than on click

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

We lose a few hundred ms of perceived user performance by waiting for a click event when selecting a toolbox tab.

As a reference, browser tabs are switching on mousedown (in Firefox, in Chrome they are switching on click). Chrome devtools tabs are also switching on mousedown.

The code driving this is at http://searchfox.org/mozilla-central/rev/51eae084534f522a502e4b808484cde8591cb502/devtools/client/framework/components/toolbox-tab.js#56

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1399180 - select devtools tab on mousedown rather than on click;

Review commit: https://reviewboard.mozilla.org/r/178838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178838/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8907151 [details]
Bug 1399180 - select devtools tab on mousedown rather than on click;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/178838/diff/1-2/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8907151 [details]
Bug 1399180 - select devtools tab on mousedown rather than on click;

https://reviewboard.mozilla.org/r/178838/#review183996

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a131a0c2d11
select devtools tab on mousedown rather than on click;r=gl

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2a131a0c2d11