Closed Bug 1399197 Opened 4 years ago Closed 3 years ago

Enable ESLint for osfile.jsm, nsURLFormatter.js and nsHelperAppDlg.js

Categories

(Toolkit :: General, enhancement, P3)

Product:
Toolkit
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox61 --- fixed

People

(Reporter: standard8, Assigned: dbugs)

Details

Attachments

(1 file)

Bug 1399197 - Enable ESLint for osfile.jsm, nsURLFormatter.js and nsHelperAppDlg.js
59 bytes, text/x-review-board-request
standard8
: review+
Details 
All of these files recently had the preprocessing removed from them, so we can now enable ESLint on them :-)

We should remove them from .eslintignore and fix the ESLint issues that are raised.
Comment on attachment 8941560 [details]
Bug 1399197 - Enable ESLint for osfile.jsm, nsURLFormatter.js and nsHelperAppDlg.js

https://reviewboard.mozilla.org/r/211820/#review217846

::: toolkit/components/urlformatter/nsURLFormatter.js:33
(Diff revision 1)
>                                    "resource://gre/modules/UpdateUtils.jsm");
>  
>  function nsURLFormatterService() {
>    XPCOMUtils.defineLazyGetter(this, "appInfo", function UFS_appInfo() {
>      return Cc["@mozilla.org/xre/app-info;1"].
> -           getService(Ci.nsIXULAppInfo).
> +           Service.appInfo(Ci.nsIXULAppInfo).

You need to drop the `Cc[...].` from the start of this. Also it should be `Services.appinfo` (notice the missing s and change for the `I`

::: toolkit/mozapps/downloads/nsHelperAppDlg.js:51
(Diff revision 1)
>      }
>    },
>  
>    // Ignore onProgressChange, onProgressChange64, onStateChange, onLocationChange, onSecurityChange, and onRefreshAttempted notifications.
> -  onProgressChange: function( aWebProgress,
> +  onProgressChange( aWebProgress,
>                                aRequest,

Please drop the space after the ( and fix the lines below so that all the preceeding `a`s align.

::: toolkit/mozapps/downloads/nsHelperAppDlg.js:58
(Diff revision 1)
>                                aMaxSelfProgress,
>                                aCurTotalProgress,
>                                aMaxTotalProgress ) {
>    },
>  
> -  onProgressChange64: function( aWebProgress,
> +  onProgressChange64( aWebProgress,

ditto.

::: toolkit/mozapps/downloads/nsHelperAppDlg.js:68
(Diff revision 1)
>                                  aMaxTotalProgress ) {
>    },
>  
>  
>  
> -  onStateChange: function( aWebProgress, aRequest, aStateFlags, aStatus ) {
> +  onStateChange( aWebProgress, aRequest, aStateFlags, aStatus ) {

Please drop the spaces after ( and before )
Attachment #8941560 - Flags: review?(standard8)
Comment on attachment 8941560 [details]
Bug 1399197 - Enable ESLint for osfile.jsm, nsURLFormatter.js and nsHelperAppDlg.js

https://reviewboard.mozilla.org/r/211820/#review238040

Looks good now, r=Standard8.
Attachment #8941560 - Flags: review?(standard8) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ac9d64f9835
Enable ESLint for osfile.jsm, nsURLFormatter.js and nsHelperAppDlg.js r=standard8
https://hg.mozilla.org/mozilla-central/rev/9ac9d64f9835
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.