Closed Bug 1399206 Opened 3 years ago Closed 3 years ago

update callers of FontBuilder.buildFontList to handle async font enumeration

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: myk, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Over in bug , I've made font enumeration asynchronous, turning the FontBuilder.buildFontList method into an async function.  It looks like there are several callers in Thunderbird that will need to be updated to account for the change:

http://searchfox.org/comm-central/search?q=fontbuilder.buildfontlist
Erm, the bug in question is bug 1375978.
Attached patch fontenum.patchSplinter Review
Straight port of https://hg.mozilla.org/integration/mozilla-inbound/rev/f255ec4e8c36#l1.1 and https://hg.mozilla.org/integration/mozilla-inbound/rev/f255ec4e8c36#l2.1

I haven't ported the CSS part as it seems not needed for us. I tested it with the M-I patch and t worked for me.

Bug 1375978 is already in M-I.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8907218 - Flags: review?(jorgk)
Depends on: 1375978
Comment on attachment 8907218 [details] [diff] [review]
fontenum.patch

Thanks, sorry, I missed the urgency of this review despite your explicit hint :-(
Attachment #8907218 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e480213445a5
Port bug 1375978 to TB: enumerate fonts asynchronously. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
What are we doing with IM?
http://searchfox.org/comm-central/source/im/content/preferences/content.js#73
Flags: needinfo?(richard.marti)
I haven't touched IM as I can't check if the change is correct. But if you want I can try it when it's only a straight port.
Flags: needinfo?(richard.marti)
Blocks: 1399410
Thanks, I filed bug 1399410 for that.
Blocks: 1399443
You need to log in before you can comment on or make changes to this bug.