update callers of FontBuilder.buildFontList to handle async font enumeration

RESOLVED FIXED in Thunderbird 57.0

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: myk, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 57.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
Over in bug , I've made font enumeration asynchronous, turning the FontBuilder.buildFontList method into an async function.  It looks like there are several callers in Thunderbird that will need to be updated to account for the change:

http://searchfox.org/comm-central/search?q=fontbuilder.buildfontlist
Reporter

Comment 1

2 years ago
Erm, the bug in question is bug 1375978.
Assignee

Comment 2

2 years ago
Straight port of https://hg.mozilla.org/integration/mozilla-inbound/rev/f255ec4e8c36#l1.1 and https://hg.mozilla.org/integration/mozilla-inbound/rev/f255ec4e8c36#l2.1

I haven't ported the CSS part as it seems not needed for us. I tested it with the M-I patch and t worked for me.

Bug 1375978 is already in M-I.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8907218 - Flags: review?(jorgk)

Updated

2 years ago
Depends on: 1375978

Comment 3

2 years ago
Comment on attachment 8907218 [details] [diff] [review]
fontenum.patch

Thanks, sorry, I missed the urgency of this review despite your explicit hint :-(
Attachment #8907218 - Flags: review?(jorgk) → review+

Comment 4

2 years ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e480213445a5
Port bug 1375978 to TB: enumerate fonts asynchronously. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Updated

2 years ago
Target Milestone: --- → Thunderbird 57.0

Comment 5

2 years ago
What are we doing with IM?
http://searchfox.org/comm-central/source/im/content/preferences/content.js#73
Flags: needinfo?(richard.marti)
Assignee

Comment 6

2 years ago
I haven't touched IM as I can't check if the change is correct. But if you want I can try it when it's only a straight port.
Flags: needinfo?(richard.marti)

Updated

2 years ago
Blocks: 1399410

Comment 7

2 years ago
Thanks, I filed bug 1399410 for that.

Updated

2 years ago
Blocks: 1399443
You need to log in before you can comment on or make changes to this bug.