1399206 - update callers of FontBuilder.buildFontList to handle async font enumeration

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Over in bug , I've made font enumeration asynchronous, turning the FontBuilder.buildFontList method into an async function.  It looks like there are several callers in Thunderbird that will need to be updated to account for the change:

http://searchfox.org/comm-central/search?q=fontbuilder.buildfontlist

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Erm, the bug in question is bug 1375978.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: fontenum.patch

Straight port of https://hg.mozilla.org/integration/mozilla-inbound/rev/f255ec4e8c36#l1.1 and https://hg.mozilla.org/integration/mozilla-inbound/rev/f255ec4e8c36#l2.1

I haven't ported the CSS part as it seems not needed for us. I tested it with the M-I patch and t worked for me.

Bug 1375978 is already in M-I.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8907218 [details] [diff] [review]
fontenum.patch

Thanks, sorry, I missed the urgency of this review despite your explicit hint :-(

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e480213445a5
Port bug 1375978 to TB: enumerate fonts asynchronously. r=jorgk DONTBUILD

Comment 5

[Jorg K (CEST = GMT+2)]

What are we doing with IM?
http://searchfox.org/comm-central/source/im/content/preferences/content.js#73

Comment 6

[Richard Marti (:Paenglab)]

I haven't touched IM as I can't check if the change is correct. But if you want I can try it when it's only a straight port.

Comment 7

[Jorg K (CEST = GMT+2)]

Thanks, I filed bug 1399410 for that.