Closed
Bug 1399217
Opened 7 years ago
Closed 7 years ago
debugger.html does not show wasm source
Categories
(DevTools :: Debugger, defect)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: yury, Assigned: yury)
References
()
Details
Attachments
(1 file, 1 obsolete file)
1.17 KB,
patch
|
Details | Diff | Splinter Review |
STR: 1. Open http://firefox-dev.tools/debugger-examples/examples/wasm/fib/fib.index.html, 2. Open degugger and refresh page, 3. Open wasm:// source Actual result: No source and “TypeError: binary is undefined[Learn More] editor.js:557:11” error message Expected result: WebAssembly code
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ydelendik
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8907204 [details] Bug 1399217 - Disable wasm disassembly for non-binary source. https://reviewboard.mozilla.org/r/178880/#review183976 r+ assuming the debugger tests pass
Attachment #8907204 -
Flags: review?(jlaster) → review+
Pushed by ydelendik@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ac5c1345f13 Disable wasm disassembly for non-binary source. r=jlast
Comment 4•7 years ago
|
||
Backed out for eslint failure at devtools/client/sourceeditor/editor.js:554: Strings must use doublequote: https://hg.mozilla.org/integration/autoland/rev/e8744e2681065da8a77f08d570509669baa8bb82 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2ac5c1345f1353b685a8e18abe31134e0c0712cf&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=130645606&repo=autoland > TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/sourceeditor/editor.js:554:38 | Strings must use doublequote. (quotes)
Flags: needinfo?(ydelendik)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8907204 -
Attachment is obsolete: true
Flags: needinfo?(ydelendik)
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cfcce8492eb2 Disable wasm disassembly for non-binary source. r=jlast
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cfcce8492eb2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 8•7 years ago
|
||
I have reproduced this bug according to (2017-09-12) Fixing bug is verified on Latest Nightly & Latest Beta-- Build ID :20170923220337 User Agent :Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0 Latest Beta-- Build ID :20170918210324 User Agent :Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0 Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20170920]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•