If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

debugger.html does not show wasm source

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
8 days ago
7 days ago

People

(Reporter: yury, Assigned: yury)

Tracking

56 Branch
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 days ago
STR:
 1. Open http://firefox-dev.tools/debugger-examples/examples/wasm/fib/fib.index.html,
 2. Open degugger and refresh page,
 3. Open wasm:// source

Actual result:
No source and “TypeError: binary is undefined[Learn More]  editor.js:557:11” error message

Expected result:
WebAssembly code
Comment hidden (mozreview-request)
(Assignee)

Updated

8 days ago
Assignee: nobody → ydelendik

Comment 2

8 days ago
mozreview-review
Comment on attachment 8907204 [details]
Bug 1399217 - Disable wasm disassembly for non-binary source.

https://reviewboard.mozilla.org/r/178880/#review183976

r+ assuming the debugger tests pass
Attachment #8907204 - Flags: review?(jlaster) → review+

Comment 3

8 days ago
Pushed by ydelendik@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ac5c1345f13
Disable wasm disassembly for non-binary source. r=jlast
Backed out for eslint failure at devtools/client/sourceeditor/editor.js:554: Strings must use doublequote:

https://hg.mozilla.org/integration/autoland/rev/e8744e2681065da8a77f08d570509669baa8bb82

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2ac5c1345f1353b685a8e18abe31134e0c0712cf&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=130645606&repo=autoland
> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/sourceeditor/editor.js:554:38 | Strings must use doublequote. (quotes)
Flags: needinfo?(ydelendik)
(Assignee)

Comment 5

8 days ago
Created attachment 8907601 [details] [diff] [review]
Disable wasm disassembly for non-binary source
Attachment #8907204 - Attachment is obsolete: true
Flags: needinfo?(ydelendik)
(Assignee)

Updated

8 days ago
Keywords: checkin-needed

Comment 6

8 days ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfcce8492eb2
Disable wasm disassembly for non-binary source. r=jlast
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cfcce8492eb2
Status: NEW → RESOLVED
Last Resolved: 7 days ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.