Closed Bug 1399217 Opened 2 years ago Closed 2 years ago

debugger.html does not show wasm source

Categories

(DevTools :: Debugger, defect)

56 Branch
defect
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: yury, Assigned: yury)

References

()

Details

Attachments

(1 file, 1 obsolete file)

STR:
 1. Open http://firefox-dev.tools/debugger-examples/examples/wasm/fib/fib.index.html,
 2. Open degugger and refresh page,
 3. Open wasm:// source

Actual result:
No source and “TypeError: binary is undefined[Learn More]  editor.js:557:11” error message

Expected result:
WebAssembly code
Assignee: nobody → ydelendik
Comment on attachment 8907204 [details]
Bug 1399217 - Disable wasm disassembly for non-binary source.

https://reviewboard.mozilla.org/r/178880/#review183976

r+ assuming the debugger tests pass
Attachment #8907204 - Flags: review?(jlaster) → review+
Pushed by ydelendik@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ac5c1345f13
Disable wasm disassembly for non-binary source. r=jlast
Attachment #8907204 - Attachment is obsolete: true
Flags: needinfo?(ydelendik)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfcce8492eb2
Disable wasm disassembly for non-binary source. r=jlast
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cfcce8492eb2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this bug according to (2017-09-12)

Fixing bug is verified on Latest Nightly & Latest Beta--
Build ID    :20170923220337
User Agent  :Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0

Latest Beta--
Build ID   :20170918210324
User Agent :Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0

Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20170920]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.