Sync shield-recipe-client v75 from GitHub (commit 321e8fb )

RESOLVED FIXED

Status

Shield
Add-on
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: mkelly, Assigned: mkelly)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed, firefox57 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

4 months ago
There have been 2 PRs since the last sync (bug 1397415) that affected the add-on:

- #1037: Fix #1036: Remove OSX-specific close button CSS for Heartbeat bar.
  https://github.com/mozilla/normandy/pull/1037

- #1058: Fix #1058: Bind PreferenceExperiment driver functions. 
  https://github.com/mozilla/normandy/pull/1060

Instead of a single sync patch, I'm going to see if attaching per-commit patches will work better.

#1058 needs to be uplifted to Beta after it lands since it's a bug in the fix for bug 1371350 that got uplifted to Beta in the last sync.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Assignee: nobody → mkelly

Comment 3

4 months ago
mozreview-review
Comment on attachment 8907268 [details]
Sync Bug 1399245: Fix mozilla/normandy#1036: Remove OSX-specific close button CSS for Heartbeat bar.

https://reviewboard.mozilla.org/r/178944/#review184050
Attachment #8907268 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 4

4 months ago
mozreview-review
Comment on attachment 8907269 [details]
Sync Bug 1399245: Fix mozilla/normandy#1058: Bind PreferenceExperiment driver functions.

https://reviewboard.mozilla.org/r/178946/#review184052
Attachment #8907269 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to Michael Kelly [:mkelly,:Osmose] from comment #0)
> There have been 2 PRs since the last sync (bug 1397415) that affected the
> add-on:
> 
> - #1037: Fix #1036: Remove OSX-specific close button CSS for Heartbeat bar.
>   https://github.com/mozilla/normandy/pull/1037
> 
> - #1058: Fix #1058: Bind PreferenceExperiment driver functions. 
>   https://github.com/mozilla/normandy/pull/1060
> 
> Instead of a single sync patch, I'm going to see if attaching per-commit
> patches will work better.

It does work a little better, but that's in part because there's not a lot of them, and they're relatively small. :-)

Comment 6

4 months ago
Pushed by mkelly@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2bd9e8d0975
Sync Bug 1399245: Fix mozilla/normandy#1036: Remove OSX-specific close button CSS for Heartbeat bar. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/9771577eeeae
Sync Bug 1399245: Fix mozilla/normandy#1058: Bind PreferenceExperiment driver functions. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/f2bd9e8d0975
https://hg.mozilla.org/mozilla-central/rev/9771577eeeae
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 8

4 months ago
Comment on attachment 8907269 [details]
Sync Bug 1399245: Fix mozilla/normandy#1058: Bind PreferenceExperiment driver functions.

Approval Request Comment
[Feature/Bug causing the regression]:
https://github.com/mozilla/normandy/issues/1058

[User impact if declined]:
Users will see an error in the browser console when preference experiment recipes run. Luckily, this shouldn't (in theory) otherwise affect our ability to run experiments, since we also write this data on shutdown.

There is a medium-to-low chance that this may also have an effect on bug 1399936 as it is related to how we save the preferences for experiments between sessions.

[Is this code covered by automated tests?]:
Yes

[Has the fix been verified in Nightly?]:
I have manually verified the latest Nightly against a local copy of the Shield experiment server.

[Needs manual test from QE? If yes, steps to reproduce]: 
No

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Very minor code change, covered by new tests added with the patch.

[String changes made/needed]:
None
Attachment #8907269 - Flags: approval-mozilla-release?
Marking 56 as affected since we intend to uplift this for the RC build.
status-firefox56: --- → affected
Comment on attachment 8907269 [details]
Sync Bug 1399245: Fix mozilla/normandy#1058: Bind PreferenceExperiment driver functions.

New shield recipe to put into place for 56 release.
Attachment #8907269 - Flags: approval-mozilla-release? → approval-mozilla-release+

Updated

4 months ago
Blocks: 1403758
You need to log in before you can comment on or make changes to this bug.