Closed Bug 1399247 Opened 2 years ago Closed 2 years ago

OMTP can hang because of D3D11 lock race condition

Categories

(Core :: Graphics, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- unaffected

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Currently we hold the D3D11 lock excessively long in D3D11TextureData::Create. This causes to have it held while we grab the D2D lock in some cases, since D2D internally grabs these locks in a different order this can cause a race condition.
Comment on attachment 8907283 [details]
Bug 1399247: Limit the scope of D3D11MTAutoEnter in order to avoid holding it while grabbing the D2D lock.

https://reviewboard.mozilla.org/r/178950/#review184048
Attachment #8907283 - Flags: review?(mchang) → review+
Priority: -- → P1
Whiteboard: [gfx-noted]
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a98262b2acc1
Limit the scope of D3D11MTAutoEnter in order to avoid holding it while grabbing the D2D lock. r=mchang
https://hg.mozilla.org/mozilla-central/rev/a98262b2acc1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.