Closed Bug 1399274 Opened 2 years ago Closed 2 years ago

text-layers: invisible text doesn't have shadows

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Gankra, Assigned: Gankra)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-mvp])

Attachments

(1 file)

We need the glyphs to get the shadows, and we get the glyphs from the font code. But the font code notices the glyphs are invisible and doesn't output them.

Need to disable that optimization if webrender is happening.
Whiteboard: [wr-mvp] [triage]
Assignee: nobody → a.beingessner
Comment on attachment 8907788 [details]
Bug 1399274 - Block invisible text optimizations when using WebRender.

https://reviewboard.mozilla.org/r/179472/#review184640
Attachment #8907788 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
Target Milestone: --- → mozilla57
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b22037b06fb6
Block invisible text optimizations when using WebRender. r=jrmuizel
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b22037b06fb6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.