MDSM doesn't exit buffering as soon as mCanPlayThrough becomes true

RESOLVED FIXED in Firefox 57

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
http://searchfox.org/mozilla-central/rev/e76c0fee79a34a3612740b33508276f4b37c3ee8/dom/html/HTMLMediaElement.cpp#5767,5819

It just early returns without having a chance to call mDecoder->CanPlayThrough() below. We want the side effect of mDecoder->CanPlayThrough() to update mCanPlayThrough in MDSM so it can exit buffering as soon as possible.
(Assignee)

Updated

2 months ago
Assignee: nobody → jwwang
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Updated

2 months ago
Attachment #8907424 - Flags: review?(gsquelart)

Comment 2

2 months ago
mozreview-review
Comment on attachment 8907424 [details]
Bug 1399358 - call mDecoder->CanPlayThrough() so MDSM has a chance to exit buffering quickly.

https://reviewboard.mozilla.org/r/179110/#review184214
Attachment #8907424 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 3

2 months ago
Thanks!

Comment 4

2 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d322180c3186
call mDecoder->CanPlayThrough() so MDSM has a chance to exit buffering quickly. r=gerald
https://hg.mozilla.org/mozilla-central/rev/d322180c3186
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.