Closed
Bug 1399358
Opened 7 years ago
Closed 7 years ago
MDSM doesn't exit buffering as soon as mCanPlayThrough becomes true
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
http://searchfox.org/mozilla-central/rev/e76c0fee79a34a3612740b33508276f4b37c3ee8/dom/html/HTMLMediaElement.cpp#5767,5819 It just early returns without having a chance to call mDecoder->CanPlayThrough() below. We want the side effect of mDecoder->CanPlayThrough() to update mCanPlayThrough in MDSM so it can exit buffering as soon as possible.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jwwang
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8907424 -
Flags: review?(gsquelart)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8907424 [details] Bug 1399358 - call mDecoder->CanPlayThrough() so MDSM has a chance to exit buffering quickly. https://reviewboard.mozilla.org/r/179110/#review184214
Attachment #8907424 -
Flags: review?(gsquelart) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d322180c3186 call mDecoder->CanPlayThrough() so MDSM has a chance to exit buffering quickly. r=gerald
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d322180c3186
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•